fix: CoachMarkContext and SlottedContextValue types for autocomplete#9423
Merged
reidbarber merged 1 commit intoadobe:mainfrom Jan 7, 2026
Merged
fix: CoachMarkContext and SlottedContextValue types for autocomplete#9423reidbarber merged 1 commit intoadobe:mainfrom
reidbarber merged 1 commit intoadobe:mainfrom
Conversation
snowystinger
reviewed
Jan 3, 2026
Member
snowystinger
left a comment
There was a problem hiding this comment.
Thanks, the CoachMark one looks like it's now being handled the same way as the Button in S2, so I think that's fine.
for better prop handling
snowystinger
approved these changes
Jan 5, 2026
reidbarber
approved these changes
Jan 7, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9422
Note that this PR fix the type which is technically breaking, as it makes the type validation function properly.
The change to
CoachMark.tsxshows the breakage:Although the breakage can be "avoided" by:
Keeping the
Partial<T>in user land is more flexible and more correct, e.g. if the user want to NOT doingPartial<T>for their specific use case.✅ Pull Request Checklist:
📝 Test Instructions:
Run
yarn check-types