Skip to content

Adapted plotting functions to work without cistopic object.#205

Open
SeppeDeWinter wants to merge 2 commits intopycistopic_v3from
update_plotting_functions
Open

Adapted plotting functions to work without cistopic object.#205
SeppeDeWinter wants to merge 2 commits intopycistopic_v3from
update_plotting_functions

Conversation

@SeppeDeWinter
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

@SeppeDeWinter SeppeDeWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DadaAb Thanks for the changes.

Looks good, one small comment.

target: str = "cell",
k: int = 10,
res: list[float] | None = None,
res: list[float] = [0.6],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a list as default can cause unexpected results
See: https://docs.python-guide.org/writing/gotchas/

Better to use

def find_clusters(
    ...,
    res: list[float] | None  = None,
    ...
)

and in the function body

if res is None:
   res = [0.6]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant