Skip to content

refactor: add max sync errors threshold and asset cleanup#567

Merged
afadil merged 1 commit intofeature/v3-beta-1from
afadil/quote-sync-review
Feb 6, 2026
Merged

refactor: add max sync errors threshold and asset cleanup#567
afadil merged 1 commit intofeature/v3-beta-1from
afadil/quote-sync-review

Conversation

@afadil
Copy link
Owner

@afadil afadil commented Feb 6, 2026

Description

Adds error threshold handling to quote sync system and improves cleanup:

  • Introduces MAX_SYNC_ERRORS constant (10) to skip assets with too many consecutive failures
  • Prevents wasted API calls on persistently failing assets unless user triggers manual resync
  • Cleans up sync state when assets are deleted to prevent orphaned records
  • Removes unused ValidationResult struct and related code
  • Includes comprehensive architecture documentation for quote sync orchestration

Checklist

  • Code changes tested and verified
  • Architecture documented with known edge cases and potential improvements

By submitting this PR, I agree to the CLA in CLA.md.

- Add MAX_SYNC_ERRORS constant (10) to skip assets with too many failures
- Skip assets exceeding error count in both filter and per-asset sync paths
- Remove unused ValidationResult struct from quote validator
- Clean up sync state when asset is deleted to prevent orphaned records
- Add TooManyErrors variant to AssetSkipReason enum
- Add comprehensive quote-sync-design.md architecture documentation

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@afadil afadil merged commit 3566cfd into feature/v3-beta-1 Feb 6, 2026
0 of 2 checks passed
0ri0nRo pushed a commit to 0ri0nRo/wealthfolio that referenced this pull request Feb 15, 2026
refactor: add max sync errors threshold and asset cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant