Conversation
- normalize and persist instrument exchange MIC across frontend/core/sqlite - derive quote_ccy from MIC for market-priced profile updates - add AssetsUpdated domain event and planner support in tauri/server - remove direct recalc triggers from asset command/API handlers - avoid prepare-time AssetsUpdated emissions via silent quote-mode updates in activity flows - add XTAI_OTC exchange metadata and include it in TWD currency priority
…que ID generation. fixes #572
…tle generation logic in title_generator.rs - Changed default model from "deepseek-r1:8b" to "ministral-3" and updated title model ID to "deepssek-3". - Refactored title generation to prioritize the title model over the chat model, with improved error handling and fallback mechanisms.
…et handling - Introduced AssetInfo struct to encapsulate asset details for improved clarity. - Removed redundant currency normalization logic and consolidated asset retrieval process. - Updated build_live_holdings_from_snapshot method to enhance efficiency and readability.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c397587bf2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
crates/ai/src/ai_providers.json
Outdated
| "defaultModel": "deepseek-r1:8b", | ||
| "titleModelId": "ministral-3", | ||
| "defaultModel": "ministral-3", | ||
| "titleModelId": "deepssek-3", |
There was a problem hiding this comment.
titleModelId is configured as deepssek-3, but that key does not exist in this provider’s models list, so the first title-generation attempt will always target an invalid model. With the new retry logic in title_generator.rs (title model first, then chat model), this introduces a guaranteed failed request on each Ollama title generation, adding avoidable latency and warning noise for users on the default config.
Useful? React with 👍 / 👎.
Fix/v3 dependecies upgrade
1 participant
Description
This pull request introduces several enhancements and adjustments across the addon and frontend codebases. The main changes are updates to test data structure, improvements in parsing logic, and the addition of a new dependency and prop for frontend components.
Frontend Enhancements
nanoidpackage as a dependency inapps/frontend/package.jsonfor unique ID generation.selectedExchangeMicto theTickerSearchInputcomponent, enabling display context for canonical asset values and improving UX for asset selection. [1] [2]useEffectin the imports forticker-search.tsx, preparing the component for future enhancements or side-effect handling.Checklist
Contributor License Agreement.
By submitting this PR, I agree to the
CLA.