Tests failing since three 179

[vincentfretin]

We have a test failing since the update to three 179 it seems
https://github.com/aframevr/aframe/actions/runs/18697088612/job/53317241965

SUMMARY:
✔ 217 tests completed
✖ 2 tests failed

FAILED TESTS:
  material
    update
      ✖ invokes XHR if <img> not cached
        Chrome 143.0.0.0 (Linux x86_64)
      AssertionError: expected false to be truthy
          at AEntity.<anonymous> (build/commons.js:246474:16)
          at AEntity.emit (build/commons.js:161569:10)
          at handleTextureEvents (build/commons.js:236126:6)
          at setMap (build/commons.js:235939:5)
          at updateTexture (build/commons.js:235911:5)

  ✖ "after each" hook for "invokes XHR if <img> not cached"
    Chrome 143.0.0.0 (Linux x86_64)
  AssertionError: expected false to be truthy
      at AEntity.<anonymous> (build/commons.js:246474:16)
      at AEntity.emit (build/commons.js:161569:10)
      at handleTextureEvents (build/commons.js:236126:6)
      at setMap (build/commons.js:235939:5)
      at updateTexture (build/commons.js:235911:5)

Before the change to three 179
https://github.com/aframevr/aframe/actions/runs/17928129256/job/50979221320

SUMMARY:
✔ 1147 tests completed
ℹ 18 tests skipped

Locally on my machine before 179

git checkout 96e2f2ddcf5cf916bfd4116924383343d8ba0ad7
npm install
npm run test:chrome
✔ 1146 tests completed
ℹ 8 tests skipped
✖ 11 tests failed

FAILED TESTS:
  obj-model
    ✖ can load .OBJ + .MTL
      Chrome 143.0.0.0 (Linux x86_64)
    Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

    ✖ can load .OBJ + .MTL with url()
      Chrome 143.0.0.0 (Linux x86_64)
    Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

  vive-controls
    model
      ✖ loads
        Chrome 143.0.0.0 (Linux x86_64)
      Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

    button colors
      ✖ has trigger at default color
        Chrome 143.0.0.0 (Linux x86_64)
      Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

      ✖ has touchpad at default color
        Chrome 143.0.0.0 (Linux x86_64)
      Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

      ✖ has grips at default colors
        Chrome 143.0.0.0 (Linux x86_64)
      Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

      ✖ sets trigger to highlight color when down
        Chrome 143.0.0.0 (Linux x86_64)
      Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

      ✖ sets trigger back to default color when up
        Chrome 143.0.0.0 (Linux x86_64)
      Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

      ✖ sets touchpad to highlight color when down
        Chrome 143.0.0.0 (Linux x86_64)
      Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

      ✖ does not change color for trigger touch
        Chrome 143.0.0.0 (Linux x86_64)
      Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

      ✖ does not change color for touchpad touch
        Chrome 143.0.0.0 (Linux x86_64)
      Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

I did another run I got

✔ 1157 tests completed
ℹ 8 tests skipped

current master, I have the same as GitHub CI

SUMMARY:
✔ 217 tests completed
✖ 2 tests failed

FAILED TESTS:
  material
    update
      ✖ invokes XHR if <img> not cached
        Chrome 143.0.0.0 (Linux x86_64)
      AssertionError: expected false to be truthy
          at AEntity.<anonymous> (build/commons.js:33060:16)
          at AEntity.emit (build/commons.js:20656:10)
          at handleTextureEvents (build/commons.js:29070:6)
          at setMap (build/commons.js:28954:5)
          at updateTexture (build/commons.js:28940:5)

  ✖ "after each" hook for "invokes XHR if <img> not cached"
    Chrome 143.0.0.0 (Linux x86_64)
  AssertionError: expected false to be truthy
      at AEntity.<anonymous> (build/commons.js:33060:16)
      at AEntity.emit (build/commons.js:20656:10)
      at handleTextureEvents (build/commons.js:29070:6)
      at setMap (build/commons.js:28954:5)
      at updateTexture (build/commons.js:28940:5)

[vincentfretin]

I confirm something changed in threejs 178 or 179 that broke the tests. The tests pass in 177.
My guess is this has to do with a change in 178, maybe mrdoob/three.js#31258 ?

[vincentfretin]

This is this test that fails

aframe/tests/components/material.test.js

Lines 190 to 199 in b0148d9

	test('invokes XHR if <img> not cached', function (done) {
	var imageLoaderSpy = this.sinon.spy(THREE.ImageLoader.prototype, 'load');
	el.addEventListener('materialtextureloaded', function () {
	assert.ok(imageLoaderSpy.called);
	assert.ok(IMG_SRC in THREE.Cache.files);
	THREE.ImageLoader.prototype.load.restore();
	done();
	});
	el.setAttribute('material', 'src', IMG_SRC);
	});

If I do a build of super-three 181 with src/loaders/ImageLoader.js from 177, that test fail is gone, but I have another one failing

SUMMARY:
✔ 498 tests completed
ℹ 3 tests skipped
✖ 2 tests failed

FAILED TESTS:
  a-asset-item
    ✖ loads as arraybuffer
      Chrome 143.0.0.0 (Linux x86_64)
    AssertionError: expected false to be truthy
        at AAssetItem.<anonymous> (build/commons.js:39236:14)
        at AAssetItem.emit (build/commons.js:22370:10)
        at emitLoaded (build/commons.js:22217:12)

  ✖ "after each" hook for "loads as arraybuffer"
    Chrome 143.0.0.0 (Linux x86_64)
  AssertionError: expected false to be truthy
      at AAssetItem.<anonymous> (build/commons.js:39236:14)
      at AAssetItem.emit (build/commons.js:22370:10)
      at emitLoaded (build/commons.js:22217:12)

That test:

aframe/tests/core/a-assets.test.js

Lines 320 to 332 in b0148d9

	test('loads as arraybuffer', function (done) {
	var assetItem = document.createElement('a-asset-item');
	THREE.Cache.remove(XHR_SRC);
	assetItem.setAttribute('src', XHR_SRC);
	assetItem.setAttribute('response-type', 'arraybuffer');
	assetItem.addEventListener('loaded', function (evt) {
	assert.ok(assetItem.data !== null);
	assert.ok(assetItem.data instanceof ArrayBuffer);
	done();
	});
	this.assetsEl.appendChild(assetItem);
	document.body.appendChild(this.sceneEl);
	});

[vincentfretin]

@mrxz you may have a better idea of what changed, I see you commented on that threejs PR. Do we need to change something in the material texture loading or the tests need to be adapted?

[vincentfretin]

I'm debugging the test, renaming test to test.only and running npm run test:chrome
The assert
assert.ok(imageLoaderSpy.called); is ok, the one that fails is
assert.ok(IMG_SRC in THREE.Cache.files)

console.log(THREE.Cache.files) gives
LOG: Object{image:/base/tests/assets/test.png: <img crossorigin="anonymous" src="/base/tests/assets/test.png">}
console.log(IMG_SRC) gives
/base/tests/assets/test.png

the THREE.Cache.files structure changed?

[vincentfretin]

on 177
LOG: Object{/base/tests/assets/test.png: <img crossorigin="anonymous" src="/base/tests/assets/test.png">}

[vincentfretin]

The structure didn't change, that's the key that has now an 'image:' prefix.

Searching Cache.files in the repo, it seems only the tests are impacted

tests/core/a-assets.test.js
23:    THREE.Cache.files = {};
84:      assert.equal(THREE.Cache.files[IMG_SRC], img);

tests/components/material.test.js
176:      THREE.Cache.files[IMG_SRC] = img;
182:        delete THREE.Cache.files[IMG_SRC];
194:        console.log(THREE.Cache.files, IMG_SRC)
195:        assert.ok(IMG_SRC in THREE.Cache.files);

tests/components/sound.test.js
8:    THREE.Cache.files = {}

so fixing those tests should be enough.

[vincentfretin]

But I don't understand where this "image:" prefix is coming from. I don't see any change in ImageLoader.js or Cache.js related to this.

[vincentfretin]

Ah found it mrdoob/three.js@cdd6c5b not sure what I was looking at before.
Hum that's probably not only tests fixes then, we have THREE.Cache.add calls src/core/a-assets.js for img and video and THREE.Cache.remove in src/components/sound.js we probably need to add the correct prefix there.

[vincentfretin]

PR #5776 fixes the issue.