feat: convert InsightsBookingService to use Prisma.sql raw queries

[everettbu]

Test 5

[greptile-apps]

Greptile Summary

This PR refactors the InsightsBookingService from using Prisma's ORM query builder to raw SQL queries via Prisma.sql. The changes convert the service from returning type-safe Prisma WHERE conditions to returning raw SQL fragments that can be composed into larger queries.

Key architectural changes include:

• Service Interface Change: The constructor now accepts InsightsBookingServicePublicOptions instead of validated options, suggesting a move toward more flexible parameter handling
• Method Restructuring: The findMany method is removed and replaced with getBaseConditions() that returns Prisma.Sql fragments instead of executing queries directly
• Authorization Logic: Complex authorization conditions for user, team, and organization scopes are now built using SQL string interpolation with Prisma.sql templates
• Filter Implementation: Event type and member user filters are converted to raw SQL conditions using parameterized queries

The integration tests have been comprehensively updated to expect Prisma.Sql fragments instead of Prisma query objects, with a new NOTHING_CONDITION constant (Prisma.sql\1=0``) for handling invalid cases. The final integration test demonstrates the new usage pattern where the service provides SQL conditions for composition into raw queries.

This refactoring appears to be part of a performance optimization initiative, as raw SQL queries can offer better performance for complex analytics workloads typical in insights/reporting systems. The change maintains Prisma's parameterization benefits while giving developers direct control over SQL generation.

Confidence score: 2/5

• This PR introduces significant security and maintainability risks that make it unsafe to merge in its current state
• The conversion to raw SQL introduces potential SQL injection vulnerabilities, loss of type safety, and complex string construction logic that could lead to runtime errors
• Files requiring immediate attention: packages/lib/server/service/insightsBooking.ts for security review and packages/lib/server/service/__tests__/insightsBooking.integration-test.ts for test coverage validation

_{2 files reviewed, 1 comment}

_{Edit Code Review Bot Settings | Greptile}

[greptile-apps]

logic: SQL condition composition logic doesn't handle the case where authConditions could be NOTHING_CONDITION - this may result in invalid SQL like (1=0) AND (other_condition)

[github-actions]

This PR is being marked as stale due to inactivity.

[GitHoobar]

Review Summary

🏷️ Draft Comments (1)

Skipped posting 1 draft comments that were valid but scored below your review threshold (>=13/15). Feel free to update them here.

packages/lib/server/service/__tests__/insightsBooking.integration-test.ts (1)

100-139: createTestData uses multiple sequential Prisma writes in loops, causing N+1 DB calls and slow test setup for large moreTeamsAndUsers arrays.

📊 Impact Scores:

• Production Impact: 2/5
• Fix Specificity: 3/5
• Urgency Impact: 2/5
• Total Score: 7/15

🤖 AI Agent Prompt (Copy & Paste Ready):

Optimize the test data setup in packages/lib/server/service/__tests__/insightsBooking.integration-test.ts, lines 100-139. The current implementation performs multiple sequential Prisma writes in nested loops, causing N+1 database calls and slow test setup for large moreTeamsAndUsers arrays. Refactor the code to use Prisma.createMany and batch fetching for users and memberships, minimizing the number of DB roundtrips. Ensure the new code preserves the original logic and data structure.

---