Allow ClientResponse to define custom flow control#100
Allow ClientResponse to define custom flow control#100kxepal wants to merge 1 commit intoaio-libs:streamreader-payloadfrom kxepal:streamreader-payload-custom-flowcontrol
Conversation
Also make DataQueue act as like as StreamReader to let FlowControlStreamReader get able to be replaced by FlowControlDataQueue preserving the common behaviour.
|
LGTM |
|
Idea for DataQueue that it can hold any value from parser. and None of empty bytes string are valid values. and with this change i need to treat empty bytes specially as it is not part of what parser emits. even if we decide to accept this change we cannot just return empty bytes, we have define sentinel const and then expose as public api, etc. example is websockets, servers it receives aiohttp.websockets.Message objects. so my opinion is -1 |
|
please create PR against master. just read your comment on 87, we can add special DataQueue that works with bytes objects. and it can inherit from FlowControlDataQueue and it can return b"" instead of EofStream. |
|
Ah, I didn't mind another cases when DataQueue may be used. Agreed for having special class to handle this case. |
Also make DataQueue act as like as StreamReader to let FlowControlStreamReader get able to be replaced by FlowControlDataQueue preserving the common behaviour.