Skip to content

Encourage creation of aiohttp objects from coroutines#3372

Merged
asvetlov merged 9 commits intomasterfrom
encourage-coroutine
Oct 30, 2018
Merged

Encourage creation of aiohttp objects from coroutines#3372
asvetlov merged 9 commits intomasterfrom
encourage-coroutine

Conversation

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Oct 30, 2018

Fixes #3331

@asvetlov asvetlov requested a review from webknjaz as a code owner October 30, 2018 17:39
@aio-libs-bot aio-libs-bot added the good first issue Good for newcomers label Oct 30, 2018
@kxepal
Copy link
Member

kxepal commented Oct 30, 2018

This wouldn't affect creation of web.Application object, right?

@asvetlov
Copy link
Member Author

In web.Application loop parameter is deprecated already.

@kxepal
Copy link
Member

kxepal commented Oct 30, 2018

Ah, right. Thanks!

@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bot:chronographer:provided There is a change note present in this PR good first issue Good for newcomers outdated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encourage creation of aiohttp public objects inside a coroutine

3 participants