Fix StreamResponse.prepared not returning True after EOF is sent#5344
Merged
Dreamsorcerer merged 4 commits intoaio-libs:masterfrom Aug 26, 2024
Merged
Fix StreamResponse.prepared not returning True after EOF is sent#5344Dreamsorcerer merged 4 commits intoaio-libs:masterfrom
Dreamsorcerer merged 4 commits intoaio-libs:masterfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5344 +/- ##
==========================================
- Coverage 98.24% 98.23% -0.01%
==========================================
Files 107 107
Lines 34110 34114 +4
Branches 4049 4049
==========================================
+ Hits 33511 33513 +2
- Misses 423 424 +1
- Partials 176 177 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
This PR seems to have been missed. Thanks @arthurdarcet. |
bdraco
approved these changes
Aug 24, 2024
bdraco
changed the title
bdraco
changed the title
Dreamsorcerer
removed
the
bot:chronographer:provided
psf-chronographer
bot
added
the
bot:chronographer:provided
Contributor
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8893 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
(cherry picked from commit bff7631)
Contributor
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8894 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
(cherry picked from commit bff7631)
Dreamsorcerer
pushed a commit
that referenced
this pull request
Aug 26, 2024
Dreamsorcerer
pushed a commit
that referenced
this pull request
Aug 26, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5343
I renamed a few tests (i think the
preparedattribute used to be namedstartedand the tests were not renamed?)And I removed some asserts around prepare in a
test___repr__test - to move them to a dedicated test