Skip to content

docs: minor grammar fix in client_reference.rst#8804

Merged
Dreamsorcerer merged 3 commits intoaio-libs:masterfrom
dimaqq:patch-1
Aug 23, 2024
Merged

docs: minor grammar fix in client_reference.rst#8804
Dreamsorcerer merged 3 commits intoaio-libs:masterfrom
dimaqq:patch-1

Conversation

@dimaqq
Copy link
Copy Markdown
Contributor

@dimaqq dimaqq commented Aug 21, 2024

No description provided.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.10 labels Aug 21, 2024
@dimaqq
Copy link
Copy Markdown
Contributor Author

dimaqq commented Aug 22, 2024

Can a maintainer close and reopen the PR?

Or, if you agree that the change is trivial, just merge it maybe :)

The test failed with:

error - 2024-08-21 18:15:09,694 -- Upload failed: {"detail":"Not valid tokenless upload"}
Error: Codecov: 
                        Failed to properly upload report: The process '/home/runner/work/_actions/codecov/test-results-action/v1/dist/codecov' failed with exit code 1

Which usually means that since I'm an outside collaborator and could inject something in the PR to steal the CI secrets, the CI doesn't make the secrets available to the test run.

Dreamsorcerer and others added 2 commits August 22, 2024 20:15
Co-authored-by: Dima Tisnek <dimaqq@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (17bf912) to head (f19c076).
Report is 1076 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8804   +/-   ##
=======================================
  Coverage   98.23%   98.24%           
=======================================
  Files         107      107           
  Lines       34088    34107   +19     
  Branches     4049     4050    +1     
=======================================
+ Hits        33487    33507   +20     
+ Misses        425      424    -1     
  Partials      176      176           
Flag Coverage Δ
CI-GHA 98.13% <ø> (+<0.01%) ⬆️
OS-Linux 97.78% <ø> (+<0.01%) ⬆️
OS-Windows 96.18% <ø> (+0.02%) ⬆️
OS-macOS 97.47% <ø> (+0.02%) ⬆️
Py-3.10.11 97.55% <ø> (+0.01%) ⬆️
Py-3.10.14 97.48% <ø> (+<0.01%) ⬆️
Py-3.11.9 97.72% <ø> (-0.01%) ⬇️
Py-3.12.4 95.98% <ø> (-1.85%) ⬇️
Py-3.12.5 97.52% <ø> (+<0.01%) ⬆️
Py-3.9.13 97.45% <ø> (+0.03%) ⬆️
Py-3.9.19 97.38% <ø> (+<0.01%) ⬆️
Py-pypy7.3.16 96.99% <ø> (+<0.01%) ⬆️
VM-macos 97.47% <ø> (+0.02%) ⬆️
VM-ubuntu 97.78% <ø> (+<0.01%) ⬆️
VM-windows 96.18% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 8156789 into aio-libs:master Aug 23, 2024
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Aug 23, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/8156789a1a1c6413233986b372dc933f5c13d712/pr-8804

Backported as #8856

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Aug 23, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/8156789a1a1c6413233986b372dc933f5c13d712/pr-8804

Backported as #8857

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 23, 2024
Dreamsorcerer pushed a commit that referenced this pull request Aug 23, 2024
…reference.rst (#8856)

**This is a backport of PR #8804 as merged into master
(8156789).**

Co-authored-by: Dima Tisnek <dimaqq@gmail.com>
Dreamsorcerer pushed a commit that referenced this pull request Aug 23, 2024
…reference.rst (#8857)

**This is a backport of PR #8804 as merged into master
(8156789).**

Co-authored-by: Dima Tisnek <dimaqq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants