Skip to content

Format status lines with f-strings#8846

Merged
bdraco merged 1 commit intomasterfrom
format_status_line_fstring
Aug 23, 2024
Merged

Format status lines with f-strings#8846
bdraco merged 1 commit intomasterfrom
format_status_line_fstring

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Aug 23, 2024

What do these changes do?

Format status lines with f-strings

Are there changes in behavior for the user?

no, maybe a tiny performance improvement

Is it a substantial burden for the maintainers to support this?

no

@bdraco bdraco added backport-3.10 bot:chronographer:skip This PR does not need to include a change note labels Aug 23, 2024
@codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (6c1d121) to head (d9a1a45).
Report is 1094 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8846      +/-   ##
==========================================
+ Coverage   98.14%   98.24%   +0.09%     
==========================================
  Files         107      107              
  Lines       34067    34108      +41     
  Branches     4030     4050      +20     
==========================================
+ Hits        33435    33508      +73     
+ Misses        456      424      -32     
  Partials      176      176
Flag Coverage Δ
CI-GHA 98.13% <100.00%> (+0.09%) ⬆️
OS-Linux 97.78% <100.00%> (+0.09%) ⬆️
OS-Windows 96.18% <100.00%> (+0.12%) ⬆️
OS-macOS 97.47% <100.00%> (+0.11%) ⬆️
Py-3.10.11 97.55% <100.00%> (+0.12%) ⬆️
Py-3.10.14 97.49% <100.00%> (+0.09%) ⬆️
Py-3.11.9 97.72% <100.00%> (+0.09%) ⬆️
Py-3.12.4 95.98% <100.00%> (-1.73%) ⬇️
Py-3.12.5 97.52% <100.00%> (+0.40%) ⬆️
Py-3.8.10 ?
Py-3.8.18 ?
Py-3.9.13 97.45% <100.00%> (+0.11%) ⬆️
Py-3.9.19 97.38% <100.00%> (+0.09%) ⬆️
Py-pypy7.3.16 96.99% <100.00%> (+0.08%) ⬆️
VM-macos 97.47% <100.00%> (+0.11%) ⬆️
VM-ubuntu 97.78% <100.00%> (+0.09%) ⬆️
VM-windows 96.18% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 23, 2024 01:30
@bdraco bdraco requested a review from asvetlov as a code owner August 23, 2024 01:30
@bdraco
Copy link
Member Author

bdraco commented Aug 23, 2024

Thanks for the 👀

@bdraco bdraco merged commit 4dd8c80 into master Aug 23, 2024
@bdraco bdraco deleted the format_status_line_fstring branch August 23, 2024 14:38
@patchback
Copy link
Contributor

patchback bot commented Aug 23, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/4dd8c807774aee39f9d6fbe16f1ed11388aa9498/pr-8846

Backported as #8868

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 23, 2024
@bdraco @patchback
Format status lines with f-strings (#8846)
5e452ca 
(cherry picked from commit 4dd8c80)
@patchback patchback bot mentioned this pull request Aug 23, 2024
Merged
@patchback
Copy link
Contributor

patchback bot commented Aug 23, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/4dd8c807774aee39f9d6fbe16f1ed11388aa9498/pr-8846

Backported as #8869

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 23, 2024
@bdraco @patchback
Format status lines with f-strings (#8846)
a9b390d 
(cherry picked from commit 4dd8c80)
@patchback patchback bot mentioned this pull request Aug 23, 2024
Merged
bdraco added a commit that referenced this pull request Aug 23, 2024
@patchback @bdraco
[PR #8846/4dd8c807 backport][3.11] Format status lines with f-strings (…
3b3156e 
…#8869)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Aug 23, 2024
@patchback @bdraco
[PR #8846/4dd8c807 backport][3.10] Format status lines with f-strings (…
5948290 
…#8868)

**This is a backport of PR #8846 as merged into master
(4dd8c80).**

<!-- Thank you for your contribution! -->

## What do these changes do?

Format status lines with f-strings

## Are there changes in behavior for the user?

no, maybe a tiny performance improvement

## Is it a substantial burden for the maintainers to support this?
no

Co-authored-by: J. Nick Koston <nick@koston.org>
@booniepepper booniepepper mentioned this pull request Sep 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz approved these changes

@Dreamsorcerer Dreamsorcerer Dreamsorcerer approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdraco @webknjaz @Dreamsorcerer