Skip to content

Fix unclosed transport warning#8875

Merged
Dreamsorcerer merged 5 commits intomasterfrom
Dreamsorcerer-patch-5
Aug 26, 2024
Merged

Fix unclosed transport warning#8875
Dreamsorcerer merged 5 commits intomasterfrom
Dreamsorcerer-patch-5

Conversation

@Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Aug 24, 2024

Fixes #5426.

@Dreamsorcerer
Copy link
Member Author

Dreamsorcerer commented Aug 24, 2024 •
edited
Loading

Just checking that existing tests reliably cover the warning first.

@codecov
Copy link

codecov bot commented Aug 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (48a5e07) to head (3066eda).
Report is 1061 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8875      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files         107      107              
  Lines       34110    34108       -2     
  Branches     4049     4046       -3     
==========================================
- Hits        33511    33509       -2     
  Misses        423      423              
  Partials      176      176
Flag Coverage Δ
CI-GHA 98.13% <100.00%> (-0.01%) ⬇️
OS-Linux 97.79% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.19% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.47% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.57% <100.00%> (-0.01%) ⬇️
Py-3.10.14 97.50% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.73% <100.00%> (+<0.01%) ⬆️
Py-3.12.4 95.99% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.53% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.46% <100.00%> (-0.01%) ⬇️
Py-3.9.19 97.39% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.00% <100.00%> (+<0.01%) ⬆️
VM-macos 97.47% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.79% <100.00%> (+<0.01%) ⬆️
VM-windows 96.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dreamsorcerer
Dreamsorcerer commented Aug 24, 2024
View reviewed changes
Dreamsorcerer
Dreamsorcerer commented Aug 24, 2024
View reviewed changes
@Dreamsorcerer Dreamsorcerer requested a review from bdraco August 24, 2024 15:25
@bdraco
Copy link
Member

bdraco commented Aug 24, 2024

Looks good. Let me throw it on production before I start the day

@bdraco
Copy link
Member

bdraco commented Aug 24, 2024

Put it on production with a system that uses ssl. Forced disconnect and gracefully disconnected a few times. No errors observed

Dreamsorcerer
Dreamsorcerer commented Aug 24, 2024
View reviewed changes
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 26, 2024
@Dreamsorcerer Dreamsorcerer merged commit 0478f14 into master Aug 26, 2024
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-5 branch August 26, 2024 20:37
@patchback
Copy link
Contributor

patchback bot commented Aug 26, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/0478f143caba33c7f6b355b8513e3c26d8db7d4d/pr-8875

Backported as #8906

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 26, 2024
@Dreamsorcerer @patchback
Fix unclosed transport warning (#8875)
5b94721 
(cherry picked from commit 0478f14)
@patchback patchback bot mentioned this pull request Aug 26, 2024
Merged
@patchback
Copy link
Contributor

patchback bot commented Aug 26, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/0478f143caba33c7f6b355b8513e3c26d8db7d4d/pr-8875

Backported as #8907

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 26, 2024
@Dreamsorcerer @patchback
Fix unclosed transport warning (#8875)
c6af496 
(cherry picked from commit 0478f14)
@patchback patchback bot mentioned this pull request Aug 26, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Aug 26, 2024
@patchback @Dreamsorcerer
[PR #8875/0478f143 backport][3.11] Fix unclosed transport warning (#8907
adcdf5c 
)

**This is a backport of PR #8875 as merged into master
(0478f14).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Aug 26, 2024
@patchback @Dreamsorcerer
[PR #8875/0478f143 backport][3.10] Fix unclosed transport warning (#8906
ade02bf 
)

**This is a backport of PR #8875 as merged into master
(0478f14).**

Co-authored-by: Sam Bull <git@sambull.org>
@booniepepper booniepepper mentioned this pull request Sep 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdraco bdraco bdraco approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ResourceWarning: unclosed transport when using SSL on server

2 participants

@Dreamsorcerer @bdraco