Re-enable keep-alive on proxies#8920
Merged
Dreamsorcerer merged 3 commits intomasterfrom Aug 29, 2024
Merged
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #8920 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 107 107
Lines 34125 34138 +13
Branches 4048 4048
=======================================
+ Hits 33530 33543 +13
Misses 421 421
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8939 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
(cherry picked from commit 5cf5db5)
Dreamsorcerer
added a commit
that referenced
this pull request
Aug 29, 2024
5 tasks
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5765.
This was disabled a long time ago in #3070. From what I've seen of various issues, the sentiment from users is that this causes problems and makes proxies too slow. asvetlov himself has suggested that modern proxies today may not have the issues he was experiencing when the change was made originally.
The original change had no test and I'm not familiar enough with the proxy code to write a new test. I suggest we put this into 3.11 and see if any users report regressions.