Skip to content

Fix Site.name with empty host#8929

Merged
Dreamsorcerer merged 2 commits intomasterfrom
fix-empty-host
Aug 29, 2024
Merged

Fix Site.name with empty host#8929
Dreamsorcerer merged 2 commits intomasterfrom
fix-empty-host

Conversation

@Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Aug 29, 2024

Fixes #6585.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 29, 2024
@codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (ce9c4eb) to head (bcf05a0).
Report is 1081 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8929   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         107      107           
  Lines       34136    34141    +5     
  Branches     4048     4048           
=======================================
+ Hits        33541    33546    +5     
  Misses        421      421           
  Partials      174      174
Flag Coverage Δ
CI-GHA 98.15% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.81% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.21% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.48% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.58% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.51% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.74% <100.00%> (+<0.01%) ⬆️
Py-3.12.4 ?
Py-3.12.5 97.86% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.47% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.41% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.02% <100.00%> (+<0.01%) ⬆️
VM-macos 97.48% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.81% <100.00%> (+<0.01%) ⬆️
VM-windows 96.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit c0c3376 into master Aug 29, 2024
@Dreamsorcerer Dreamsorcerer deleted the fix-empty-host branch August 29, 2024 19:34
@patchback
Copy link
Contributor

patchback bot commented Aug 29, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/c0c3376e6699d0741424c43ac1b25beea366b1fd/pr-8929

Backported as #8934

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 29, 2024
@Dreamsorcerer @patchback
Fix Site.name with empty host (#8929)
c81a5c5 
(cherry picked from commit c0c3376)
@patchback patchback bot mentioned this pull request Aug 29, 2024
Merged
@patchback
Copy link
Contributor

patchback bot commented Aug 29, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/c0c3376e6699d0741424c43ac1b25beea366b1fd/pr-8929

Backported as #8935

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 29, 2024
@Dreamsorcerer @patchback
Fix Site.name with empty host (#8929)
e39b557 
(cherry picked from commit c0c3376)
@patchback patchback bot mentioned this pull request Aug 29, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Aug 29, 2024
@patchback @Dreamsorcerer
[PR #8929/c0c3376e backport][3.10] Fix Site.name with empty host (#8934)
6c6d45b 
**This is a backport of PR #8929 as merged into master
(c0c3376).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Aug 29, 2024
@patchback @Dreamsorcerer
[PR #8929/c0c3376e backport][3.11] Fix Site.name with empty host (#8935)
37b2604 
**This is a backport of PR #8929 as merged into master
(c0c3376).**

Co-authored-by: Sam Bull <git@sambull.org>
@booniepepper booniepepper mentioned this pull request Sep 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TCPSite.name raises ValueError if host is empty string

1 participant

@Dreamsorcerer