Skip to content

Add parameters to del_cookie() (#8956) #8959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dreamsorcerer merged 1 commit into from
Aug 31, 2024
Merged

Add parameters to del_cookie() (#8956) #8959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/8956.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added ``secure``/``httponly``/``samesite`` parameters to ``.del_cookie()`` -- by :user:`Dreamsorcerer`.
12 changes: 11 additions & 1 deletion aiohttp/web_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,14 @@ def set_cookie(
c["samesite"] = samesite

def del_cookie(
self, name: str, *, domain: Optional[str] = None, path: str = "/"
self,
name: str,
*,
domain: Optional[str] = None,
path: str = "/",
secure: Optional[bool] = None,
httponly: Optional[bool] = None,
samesite: Optional[str] = None,
) -> None:
"""Delete cookie.

Expand All @@ -266,6 +273,9 @@ def del_cookie(
expires="Thu, 01 Jan 1970 00:00:00 GMT",
domain=domain,
path=path,
secure=secure,
httponly=httponly,
samesite=samesite,
)

@property
Expand Down