Avoid logging exception from run_app() that is also raised (#8951)#8974
Merged
Dreamsorcerer merged 2 commits into3.11from Sep 1, 2024
Conversation
(cherry picked from commit 45d6e4f)
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #8974 +/- ##
=======================================
Coverage 97.73% 97.74%
=======================================
Files 108 108
Lines 34369 34382 +13
Branches 4079 4082 +3
=======================================
+ Hits 33592 33605 +13
Misses 581 581
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Dreamsorcerer
added
the
bot:chronographer:skip
Dreamsorcerer
deleted the
patchback/backports/3.11/45d6e4f14572bfc4cfc3f32a2c7c72a9cc28f125/pr-8951
branch
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 45d6e4f)