Replace Cython with pure C by asvetlov · Pull Request #394 · aio-libs/multidict

asvetlov · 2019-11-21T14:13:23Z

Co-authored-by: Igor Emelianov cybercjp@gmail.com

…actoring.

Co-Authored-By: iemelyanov <cybercjp@gmail.com>

…dict into iemelyanov-multidict_c_ext

codecov · 2019-11-21T14:17:01Z

Codecov Report

Merging #394 into master will decrease coverage by 0.97%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #394      +/-   ##
=========================================
- Coverage   76.07%   75.1%   -0.98%     
=========================================
  Files           5       5              
  Lines         464     470       +6     
=========================================
  Hits          353     353              
- Misses        111     117       +6

Impacted Files	Coverage Δ
multidict/_multidict_base.py	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f6926b...0c18710. Read the comment docs.

multidict/_multidict_c.c

asvetlov · 2019-11-21T21:41:09Z

Thanks for raised questions, I'll address them before merging.

@iemelyanov you have write access to the repo and this branch, just in case :)

iemelyanov

Looks good. I think in the future we can delete *.pxd files and remove cython from requirements.

asvetlov · 2019-11-22T06:58:47Z

I've dropped cythonization by the last commit but want to keep pxd files at least for a while.

Maybe we can reuse them as a part of our future provided public Cython-level API for easy using multidict from Cython extensions.
I can imagine how it can be useful for the aiohttp project.

asvetlov · 2019-11-22T06:59:30Z

Thanks for the review!

asvetlov · 2019-11-22T06:59:49Z

And for the vast majority of the PR's code :)

rtd-helper · 2019-11-22T07:08:36Z

😭 Failed to visit version page at https://readthedocs.org/dashboard/multidict/version/iemelyanov-multidict_c_ext/. Please make sure you have enabled GitHub integration in your RTD project.

rtd-helper · 2019-11-22T07:17:17Z

😭 Failed to visit version page at https://readthedocs.org/dashboard/multidict/version/iemelyanov-multidict_c_ext/. Please make sure you have enabled GitHub integration in your RTD project.

iemelyanov · 2019-11-22T07:41:46Z

And for the vast majority of the PR's code :)

Thank you for lots of suggestions and mentoring in this issue.

Bumps [towncrier](https://github.com/twisted/towncrier) from 23.11.0 to 25.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/twisted/towncrier/releases">towncrier's releases</a>.</em></p> <blockquote> <h2>Towncrier 25.8.0</h2> <h1>towncrier 25.8.0 (2025-08-30)</h1> <h2>Features</h2> <ul> <li>Support was added for Mercurial SCM. (<code>[#394](twisted/towncrier#394) <https://github.com/twisted/towncrier/issues/394></code>_)</li> <li>The <code>towncrier check</code> command now has a <code>--staged</code> flag to inspect the files staged for commit when checking for a news fragment: useful in a pre-commit hook (<code>[#676](twisted/towncrier#676) <https://github.com/twisted/towncrier/issues/676></code>_)</li> <li>When used with an <code>pyproject.toml</code> file, when no explicit values are defined for [tool.towncrier.name|package] they will now fallback to the value of [project.name]. (<code>[#687](twisted/towncrier#687) <https://github.com/twisted/towncrier/issues/687></code>_)</li> <li>More simple configuration for Keep a Changelog style changelogs (<code>[#691](twisted/towncrier#691) <https://github.com/twisted/towncrier/issues/691></code>_)</li> <li>Added support for Python 3.13 and removed support for Python 3.8. (<code>[#700](twisted/towncrier#700) <https://github.com/twisted/towncrier/issues/700></code>_)</li> </ul> <h2>Bugfixes</h2> <ul> <li>Multi-line newsfragments that ends with a code block will now have a newline inserted before appending the link to the issue, to avoid breaking formatting. (<code>[#614](twisted/towncrier#614) <https://github.com/twisted/towncrier/issues/614></code>_)</li> <li>Markdown header level is correctly inferred from <code>title_format</code>. (<code>[#695](twisted/towncrier#695) <https://github.com/twisted/towncrier/issues/695></code>_)</li> </ul> <h2>Improved Documentation</h2> <ul> <li>The documentation RST source files are now included in the sdist package. (<code>[#672](twisted/towncrier#672) <https://github.com/twisted/towncrier/issues/672></code>_)</li> <li>Refactor the default markdown template to make it easier to understand, extend, and customize. (<code>[#706](twisted/towncrier#706) <https://github.com/twisted/towncrier/issues/706></code>_)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>When no sections are present, the default Markdown template now renders the category headers as H2. In previous versions it was rendered as H3. (<code>[#663](twisted/towncrier#663) <https://github.com/twisted/towncrier/issues/663></code>_)</li> </ul> <h2>Misc</h2> <ul> <li><code>[#667](twisted/towncrier#667) <https://github.com/twisted/towncrier/issues/667></code><em>, <code>[#669](twisted/towncrier#669) <https://github.com/twisted/towncrier/issues/669></code></em>, <code>[#679](twisted/towncrier#679) <https://github.com/twisted/towncrier/issues/679></code><em>, <code>[#680](twisted/towncrier#680) <https://github.com/twisted/towncrier/issues/680></code></em>, <code>[#682](twisted/towncrier#682) <https://github.com/twisted/towncrier/issues/682></code><em>, <code>[#701](twisted/towncrier#701) <https://github.com/twisted/towncrier/issues/701></code></em>, <code>[#702](twisted/towncrier#702) <https://github.com/twisted/towncrier/issues/702></code><em>, <code>[#713](twisted/towncrier#713) <https://github.com/twisted/towncrier/issues/713></code></em></li> </ul> <h2>Towncrier 25.8.0rc2</h2> <h1>towncrier 25.8.0rc2 (2025-08-15)</h1> <h2>Features</h2>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's changelog</a>.</em></p> <blockquote> <h1>towncrier 25.8.0 (2025-08-30)</h1> <p>No significant changes since the previous release candidate.</p> <h2>Features</h2> <ul> <li>Support was added for Mercurial SCM. (<code>[#394](twisted/towncrier#394) <https://github.com/twisted/towncrier/issues/394></code>_)</li> <li>The :command:<code>towncrier check</code> command now has a <code>--staged</code> flag to inspect the files staged for commit when checking for a news fragment: useful in a pre-commit hook (<code>[#676](twisted/towncrier#676) <https://github.com/twisted/towncrier/issues/676></code>_)</li> <li>When used with an :file:<code>pyproject.toml</code> file, when no explicit values are defined for <code>[tool.towncrier.name|package]</code> they will now fallback to the value of <code>[project.name]</code>. (<code>[#687](twisted/towncrier#687) <https://github.com/twisted/towncrier/issues/687></code>_)</li> <li>The <code>directory</code> configuration option is no longer required. It can now be generated based on value from the <code>name</code> configuration. (<code>[#691](twisted/towncrier#691) <https://github.com/twisted/towncrier/issues/691></code>_)</li> <li>Added support for Python 3.13 and removed support for Python 3.8. (<code>[#700](twisted/towncrier#700) <https://github.com/twisted/towncrier/issues/700></code>_)</li> </ul> <h2>Bugfixes</h2> <ul> <li>Multi-line news fragments that end with a code block will now have a newline inserted before appending the link to the issue, to avoid breaking formatting. (<code>[#614](twisted/towncrier#614) <https://github.com/twisted/towncrier/issues/614></code>_)</li> <li>Markdown header level is correctly inferred from <code>title_format</code>. (<code>[#695](twisted/towncrier#695) <https://github.com/twisted/towncrier/issues/695></code>_)</li> </ul> <h2>Improved Documentation</h2> <ul> <li>The documentation RST source files are now included in the sdist package. (<code>[#672](twisted/towncrier#672) <https://github.com/twisted/towncrier/issues/672></code>_)</li> <li>Refactor the default markdown template to make it easier to understand, extend, and customize. (<code>[#706](twisted/towncrier#706) <https://github.com/twisted/towncrier/issues/706></code>_)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>Support for Python 3.8 was removed. (<code>[#700](twisted/towncrier#700) <https://github.com/twisted/towncrier/issues/700></code>_)</li> <li>When no sections are present, the default Markdown template now renders the category headers as H2. In previous versions it was rendered as H3. (<code>[#663](twisted/towncrier#663) <https://github.com/twisted/towncrier/issues/663></code>_)</li> </ul> <h2>Misc</h2> <ul> <li><code>[#667](twisted/towncrier#667) <https://github.com/twisted/towncrier/issues/667></code><em>, <code>[#669](twisted/towncrier#669) <https://github.com/twisted/towncrier/issues/669></code></em>, <code>[#679](twisted/towncrier#679) <https://github.com/twisted/towncrier/issues/679></code><em>, <code>[#680](twisted/towncrier#680) <https://github.com/twisted/towncrier/issues/680></code></em>, <code>[#682](twisted/towncrier#682) <https://github.com/twisted/towncrier/issues/682></code><em>, <code>[#701](twisted/towncrier#701) <https://github.com/twisted/towncrier/issues/701></code></em>, <code>[#702](twisted/towncrier#702) <https://github.com/twisted/towncrier/issues/702></code><em>, <code>[#713](twisted/towncrier#713) <https://github.com/twisted/towncrier/issues/713></code></em></li> </ul> <p>Towncrier 24.8.0 (2024-08-23)</p>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twisted/towncrier/commit/762c8f28d625979812db33b9446c24bee701ba0b"><code>762c8f2</code></a> Prepare final version.</li> <li><a href="https://github.com/twisted/towncrier/commit/fb2c84213a578aaefc52f02d318b93a3679254bc"><code>fb2c842</code></a> Update NEWS.rst</li> <li><a href="https://github.com/twisted/towncrier/commit/aae1d3307bda638ced5dc9da2a0ef09d02962902"><code>aae1d33</code></a> Apply suggestions from code review</li> <li><a href="https://github.com/twisted/towncrier/commit/cb696b2237e0840b171eb872ce7f5608295f9b80"><code>cb696b2</code></a> [pre-commit.ci] auto fixes from pre-commit.com hooks</li> <li><a href="https://github.com/twisted/towncrier/commit/10bbd8e5e8443bf1f0abe20fe07839302cef747f"><code>10bbd8e</code></a> Fix version string.</li> <li><a href="https://github.com/twisted/towncrier/commit/5f4639a55ba0a68da0146b000e0772bb9947a2cf"><code>5f4639a</code></a> Merge origin.</li> <li><a href="https://github.com/twisted/towncrier/commit/234ebc5dbc43f7f8539c053135cec6a5773449f3"><code>234ebc5</code></a> Fix version.</li> <li><a href="https://github.com/twisted/towncrier/commit/8547ca9a201be62f64c577d032b18aca6409e6b6"><code>8547ca9</code></a> Update releae candidate.</li> <li><a href="https://github.com/twisted/towncrier/commit/5347588877a5447d0ef01dd2093e445d74e8a583"><code>5347588</code></a> [pre-commit.ci] auto fixes from pre-commit.com hooks</li> <li><a href="https://github.com/twisted/towncrier/commit/e5853c5dd1ef69c05a66e9ac5f36f364725b458d"><code>e5853c5</code></a> Update releae candidate.</li> <li>Additional commits viewable in <a href="https://github.com/twisted/towncrier/compare/23.11.0...25.8.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=towncrier&package-manager=pip&previous-version=23.11.0&new-version=25.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

iemelyanov and others added 30 commits January 13, 2019 15:57

Impl _Base in C

26be3fc

Add build multidict_c.

289b31c

Add internal method extend and other support methods.

e528b63

Add newfunc and some pub methods add, copy, extend, clear. Lettle ref…

8167e37

…actoring.

Remove _Base class.

ec7e580

Add setitem and delitem.

c28a5e9

Massive refactoring.

8553a2b

Fix exception handling.

952392c

Refactoring.

d1749aa

Add method setdefault.

53e3501

Add method popone.

1dc500d

Add method popall.

cc909cc

Add method popitem.

26fd47d

Add method update.

ee0b773

Add todos.

1b44125

Add comment.

cbea38b

Minor refactoring.

603664a

Switch to generic new.

b68b1f9

Fix return value.

cfb85b2

Fix init.

eb4c293

Fix allocation new multidict in copy.

9947d92

Fix tp_flags.

e0493d8

Add pair_list_init with module init.

1ce8308

Fix args.

0eaae02

Add todo.

c056225

Revert unrelated changes in setup.py

41892ba

Co-Authored-By: iemelyanov <cybercjp@gmail.com>

Fix PR issues. Refactoring.

d57570f

Add pedantic flag.

d4d6e0a

Add todo.

97f9901

Add newline at end of file.

8dfe660

iemelyanov and others added 3 commits January 13, 2019 15:57

Fix pr issues. Refactoring. Switch to generic alloc and new.

7f3ae86

Merge branch 'multidict_c_ext' of https://github.com/iemelyanov/multi…

267eef9

…dict into iemelyanov-multidict_c_ext

Fix test

a45fc80

asvetlov requested review from iemelyanov and webknjaz as code owners November 21, 2019 14:13

Add changelog

9ebeaf3

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 21, 2019

iemelyanov reviewed Nov 21, 2019

View reviewed changes

multidict/_multidict_c.c Outdated Show resolved Hide resolved

iemelyanov reviewed Nov 21, 2019

View reviewed changes

multidict/_multidict_c.c Outdated Show resolved Hide resolved

iemelyanov reviewed Nov 21, 2019

View reviewed changes

multidict/_multidict_c.c Outdated Show resolved Hide resolved

asvetlov added 3 commits November 21, 2019 22:23

Refactor

d13baca

Merge branch 'master' into iemelyanov-multidict_c_ext

1204fb6

Merge branch 'master' into iemelyanov-multidict_c_ext

a87293c

asvetlov mentioned this pull request Nov 21, 2019

WIP Multidict c ext #313

Closed

asvetlov added 3 commits November 22, 2019 01:21

Drop non-actual comment

70b8b2f

tp_print -> tp_vectorcall_offset

b5b4db8

Drop INLINE macro

fb8172f

iemelyanov approved these changes Nov 22, 2019

View reviewed changes

Drop cythonization

0c18710

asvetlov merged commit 20e15f8 into master Nov 22, 2019

asvetlov deleted the iemelyanov-multidict_c_ext branch November 22, 2019 07:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replace Cython with pure C#394

Replace Cython with pure C#394
asvetlov merged 80 commits intomasterfrom
iemelyanov-multidict_c_ext

asvetlov commented Nov 21, 2019

Uh oh!

codecov bot commented Nov 21, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asvetlov commented Nov 21, 2019

Uh oh!

iemelyanov left a comment

Uh oh!

asvetlov commented Nov 22, 2019

Uh oh!

asvetlov commented Nov 22, 2019

Uh oh!

asvetlov commented Nov 22, 2019

Uh oh!

rtd-helper bot commented Nov 22, 2019

Uh oh!

rtd-helper bot commented Nov 22, 2019

Uh oh!

iemelyanov commented Nov 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

asvetlov commented Nov 21, 2019

Uh oh!

codecov bot commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asvetlov commented Nov 21, 2019

Uh oh!

iemelyanov left a comment

Choose a reason for hiding this comment

Uh oh!

asvetlov commented Nov 22, 2019

Uh oh!

asvetlov commented Nov 22, 2019

Uh oh!

asvetlov commented Nov 22, 2019

Uh oh!

rtd-helper bot commented Nov 22, 2019

Uh oh!

rtd-helper bot commented Nov 22, 2019

Uh oh!

iemelyanov commented Nov 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Nov 21, 2019 •

edited

Loading