fix(pipedream): accept source_connection_id kwarg - #1777
Open
hiddeco wants to merge 1 commit into
Open
Conversation
`PipedreamAuthProvider.get_auth_result` overrode the base method without accepting `source_connection_id`. The lifecycle caller in `domains/sources/lifecycle.py:393` always passes it (it's part of `BaseAuthProvider.get_auth_result`'s contract since the introduction of the Custom auth provider, which scopes credentials per connection), so every Pipedream-backed sync raised `TypeError: get_auth_result() got an unexpected keyword argument 'source_connection_id'` and failed before reaching the credential fetch. Production saw ~44 of these per day, contributing to the chronic sync-worker failure rate. Pipedream identifies accounts by source slug and project rather than connection id, so the value is forwarded to `get_creds_for_source` (already accepted there) but otherwise unused. A regression test in `test_pipedream` exercises the kwarg path.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
orhanrauf
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PipedreamAuthProvider.get_auth_resultoverrode the base method without acceptingsource_connection_id. The lifecycle caller indomains/sources/lifecycle.py:393always passes it (it's part ofBaseAuthProvider.get_auth_result's contract since the introduction of the Custom auth provider, which scopes credentials per connection), so every Pipedream-backed sync raisedTypeError: get_auth_result() got an unexpected keyword argument 'source_connection_id'and failed before reaching the credential fetch.Production saw ~44 of these per day, contributing to the chronic sync-worker failure rate. Pipedream identifies accounts by source slug and project rather than connection id, so the value is forwarded to
get_creds_for_source(already accepted there) but otherwise unused. A regression test intest_pipedreamexercises the kwarg path.