fix(embedders): use /.well-known/ready instead of /health for local embeddings probe (#1772) - #1784
Open
awesome-pro wants to merge 2 commits into
Conversation
…mbeddings probe The semitechnologies/transformers-inference image does not expose /health — it serves /.well-known/ready (204 when ready, 503 when not). Both the backend startup reachability check and the docker-compose healthcheck were hitting /health, always receiving 404, which caused raise_for_status() to throw and prevented local_minilm from starting. Changed three places consistently: - backend/airweave/domains/embedders/config.py — startup probe URL - docker/docker-compose.yml — text2vec-transformers healthcheck - test_local_reachability.py — expected URL in the unit test assertion Fixes airweave-ai#1772
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…eady docker-compose.test.yml was missed when fixing the semitechnologies inference health check URL in PR airweave-ai#1784. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthwith/.well-known/readyin the backend startup reachability probe and the docker-compose healthcheck for thetext2vec-transformerscontainerProblem
The
semitechnologies/transformers-inferenceimage does not expose a/healthendpoint — it serves/.well-known/ready(HTTP 204 when ready, 503 when not). Both the backend startup check and the docker-compose healthcheck were calling/health, always receiving 404, which causedraise_for_status()to throw anHTTPStatusError. This prevented thelocal_minilmembedder from ever starting, even when the container was healthy.Changes
backend/airweave/domains/embedders/config.py_validate_local_reachability:/health→/.well-known/readydocker/docker-compose.ymltext2vec-transformershealthcheck:/health→/.well-known/readybackend/airweave/domains/embedders/tests/test_local_reachability.pytest_passes_when_service_reachableTest plan
test_passes_when_service_reachableassertion updated to match the new endpoint/.well-known/readyreturns HTTP 204 (no content) when the container is healthy —raise_for_status()does not raise on 2xxFixes #1772
Summary by cubic
Switch the local embeddings health probe from /health to /.well-known/ready so the
text2vec-transformerscontainer reports healthy andlocal_minilmcan start. This avoids 404s from thesemitechnologies/transformers-inferenceimage.text2vec-transformersupdated to /.well-known/ready in bothdocker-composefiles.Written for commit 720de02. Summary will update on new commits.