fix: Allow specifying name of resources in argocd namespace#6307
Open
TBeijen wants to merge 1 commit into
Open
fix: Allow specifying name of resources in argocd namespace#6307TBeijen wants to merge 1 commit into
TBeijen wants to merge 1 commit into
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c6cd7b3 to
2a6c1f7
Compare
Open
1 task
2a6c1f7 to
14de11e
Compare
Author
|
Note: Tests done with fix applied to v1.10.4. PR takes latest Testing: git checkout v1.10.4
helm -n gitops template ./charts/kargo \
--set api.adminAccount.enabled=false \
--set controller.argocd.watchArgocdNamespaceOnly=true \
--set controller.argocd.namespace=gitops > render-v1.10.4.yaml
git checkout rbac-overwrite-fix
helm -n gitops template ./charts/kargo \
--set api.adminAccount.enabled=false \
--set controller.argocd.watchArgocdNamespaceOnly=true \
--set controller.argocd.namespace=gitops > render-rbac-fix.yaml
helm -n gitops template ./charts/kargo \
--set api.adminAccount.enabled=false \
--set controller.argocd.watchArgocdNamespaceOnly=true \
--set controller.argocd.resourceName=argo-kargo-controller \
--set controller.argocd.namespace=gitops > render-rbac-fix-resource-name.yamlResults: diff render-v1.10.4.yaml render-rbac-fix.yaml
# Nothing (good, no regression introduced)
diff render-rbac-fix.yaml render-rbac-fix-resource-name.yaml -u
# Gives:--- render-rbac-fix.yaml 2026-05-17 08:53:39
+++ render-rbac-fix-resource-name.yaml 2026-05-17 08:53:48
@@ -7437,7 +7437,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
- name: kargo-controller
+ name: argo-kargo-controller
namespace: gitops
labels:
helm.sh/chart: kargo-0.1.0
@@ -7654,7 +7654,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
- name: kargo-controller
+ name: argo-kargo-controller
namespace: gitops
labels:
helm.sh/chart: kargo-0.1.0
@@ -7666,7 +7666,7 @@
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
- name: kargo-controller
+ name: argo-kargo-controller
subjects:
- kind: ServiceAccount
namespace: gitops |
14de11e to
4fa20b4
Compare
…espace Signed-off-by: Tibo Beijen <tibobeijen@gmail.com>
4fa20b4 to
438f1f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…espace
All pull requests must reference an existing issue with no blocking labels.
PRs that do not meet this requirement will be automatically closed. See the
Contributor Guide for details.
Issue Reference
Closes #6295
Description
This PR fixes the resource name clash that occurs when installing Kargo in the same namespace as Argo.
Rationale:
Rebased on v1.10.4 to properly test (couldn't find helm chart e2e tests). See comment.
Checklist
kind/proposal,needs discussion,needs research,maintainer only,area/security,size/large,size/x-large,size/xx-large).AI Use Disclosure
Select one:
Sign-Off
git commit -s) (required)git commit -S) (encouraged)