Skip to content

Update mirror component to work with A-Frame 1.3#3

Draft
dandykong wants to merge 1 commit intoalfa256:masterfrom
netproject0:master
Draft

Update mirror component to work with A-Frame 1.3#3
dandykong wants to merge 1 commit intoalfa256:masterfrom
netproject0:master

Conversation

@dandykong
Copy link

@dandykong dandykong commented Jun 2, 2022

There's still a setFromMatrixPosition error that needs to be fixed before merging, hence the draft.

Uncaught TypeError: Cannot read properties of undefined (reading 'setFromMatrixPosition')
    at Group.getWorldPosition (three.js:5961:1)
    at i.tick (aframe-mirror-component.js:100:84)
    at HTMLElement.value (a-scene.js:739:34)
    at HTMLElement.value (a-scene.js:789:36)
    at bind.js:12:17
    at onAnimationFrame (three.js:20001:1)
    at onAnimationFrame (three.js:9460:1)

@netproject0
Update aframe-mirror-component.js
5f6c59c 
Add to solve bug for release of aFrame 1.1. : THREE.CubeCamera: The constructor now expects an instance of WebGLCubeRenderTarget as third parameter.
https://threejs.org/docs/#api/en/cameras/CubeCamera
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dandykong @netproject0