Skip to content

fix(specs): ingestion api reference#2918

Merged
shortcuts merged 14 commits into
mainfrom
docs/ingestion
Mar 28, 2024
Merged

fix(specs): ingestion api reference#2918
shortcuts merged 14 commits into
mainfrom
docs/ingestion

Conversation

@kai687

@kai687 kai687 commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

🧭 What and Why

Updates the Ingestion API reference, mostly the descriptions.

🎟 JIRA Ticket:

Changes included:

  • List changes

🧪 Test

@algolia-bot

algolia-bot commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@github-actions

github-actions Bot commented Mar 25, 2024

Copy link
Copy Markdown

@github-actions github-actions Bot temporarily deployed to pull request March 25, 2024 16:23 Inactive
@kai687 kai687 marked this pull request as ready for review March 25, 2024 16:33
@kai687 kai687 requested a review from a team as a code owner March 25, 2024 16:33
@kai687 kai687 requested review from millotp and morganleroi March 25, 2024 16:33

@shortcuts shortcuts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work as always!

Comment thread specs/ingestion/common/destinationParameters.yml Outdated
Comment thread specs/ingestion/common/observabilityParameters.yml Outdated
Comment thread specs/ingestion/common/schemas/common.yml
Comment thread specs/ingestion/common/schemas/destination.yml
Comment thread specs/ingestion/common/schemas/destination.yml Outdated
Comment thread specs/ingestion/common/schemas/event.yml
kai687 and others added 4 commits March 25, 2024 17:47
Except the discussion about the event type

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Adding support for UUID as variables seems to be more involved.
I really just want to use this as annotation for docs, not as type
validation for the clients.
@github-actions github-actions Bot temporarily deployed to pull request March 25, 2024 19:10 Inactive
@kai687 kai687 requested a review from shortcuts March 25, 2024 19:18
@github-actions github-actions Bot temporarily deployed to pull request March 26, 2024 09:40 Inactive
@kai687

kai687 commented Mar 28, 2024

Copy link
Copy Markdown
Contributor Author

@shortcuts could we merge this?

Comment thread specs/ingestion/common/schemas/authentication.yml Outdated
Comment thread specs/ingestion/common/schemas/source.yml Outdated
Comment thread specs/ingestion/common/schemas/event.yml Outdated
Comment thread specs/ingestion/common/schemas/event.yml Outdated

@shortcuts shortcuts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

@shortcuts

Copy link
Copy Markdown
Member

(again, thanks a lot for all of your contributions to the specs!)

@shortcuts shortcuts changed the title docs: ingestion api reference fix(specs): ingestion api reference Mar 28, 2024
@github-actions github-actions Bot temporarily deployed to pull request March 28, 2024 12:50 Inactive
@shortcuts shortcuts enabled auto-merge (squash) March 28, 2024 12:51
@shortcuts shortcuts merged commit b153b39 into main Mar 28, 2024
@shortcuts shortcuts deleted the docs/ingestion branch March 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants