Skip to content

fix(specs): update analytics and abtesting max pagination query limit#3696

Merged
millotp merged 7 commits into
mainfrom
docs/analytics/update_max_pagination_query_limit
Oct 3, 2024
Merged

fix(specs): update analytics and abtesting max pagination query limit#3696
millotp merged 7 commits into
mainfrom
docs/analytics/update_max_pagination_query_limit

Conversation

@febeck

@febeck febeck commented Sep 12, 2024 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

🧭 What and Why

Analytics team is enforcing the limit where combination of limit and offset can only target the top 1000 rows.
Documentation updated to reflect those updates

🎟 JIRA Ticket: OPTIM-1255

Changes included:

Limit and Offset were previously defined in a global common folder. Usages were made in analytics and one single usage in AB test.
To avoid any confusion

  • move usage with improved specificity about limit and offset into analytics
  • define single usage in AB test API locally
  • remove no-longer definition from common folder

🧪 Test

@algolia-bot

algolia-bot commented Sep 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

✔️ Code generated!

Name Link
🪓 Triggered by 1e60bbbbe39e112cc33856010e94f70ba3ebac8a
🍃 Generated commit da0d6bd392cfd5e9486393aebb3cfdfeea90a6a8
🌲 Generated branch generated/docs/analytics/update_max_pagination_query_limit
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1670
go 1551
php 1460
csharp 1382
java 1109
python 1013
ruby 865
swift 755

@febeck febeck changed the title Docs/analytics/update max pagination query limit docs(analytics): update max pagination query limit Sep 12, 2024
@febeck febeck marked this pull request as ready for review September 12, 2024 12:29
@febeck febeck requested a review from a team as a code owner September 12, 2024 12:29
@febeck febeck requested review from Fluf22 and millotp September 12, 2024 12:29
@shortcuts shortcuts changed the title docs(analytics): update max pagination query limit fix(specs): update analytics and abtesting max pagination query limit Sep 12, 2024
shortcuts
shortcuts approved these changes Sep 12, 2024
View reviewed changes

@shortcuts shortcuts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for the fix :D

@shortcuts

shortcuts commented Sep 12, 2024

Copy link
Copy Markdown
Member

should we wait for someone from your team to review as well, or is it good to go?

@cdhawke

cdhawke commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

@shortcuts we need to wait - we had to revert the change and i'll approve when we get it redeployed

@febeck febeck marked this pull request as draft September 12, 2024 14:26
@febeck

febeck commented Sep 12, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the review @shortcuts . As @cdhawke said, this change has been reverted and therefore I put the PR in draft

@febeck febeck marked this pull request as ready for review October 3, 2024 09:13
@millotp millotp merged commit ad8e3d2 into main Oct 3, 2024
@millotp millotp deleted the docs/analytics/update_max_pagination_query_limit branch October 3, 2024 09:46
algolia-bot added a commit that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit (…
a04a9f7 
…#3696) (generated) [skip ci]

Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit…
53d04e7 
… (generated)

algolia/api-clients-automation#3696

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit…
192e48f 
… (generated)

algolia/api-clients-automation#3696

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit…
1cef26d 
… (generated)

algolia/api-clients-automation#3696

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit…
8805c6d 
… (generated)

algolia/api-clients-automation#3696

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit…
90ec9b2 
… (generated)

algolia/api-clients-automation#3696

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit…
ddab809 
… (generated)

algolia/api-clients-automation#3696

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit…
601ffa5 
… (generated)

algolia/api-clients-automation#3696

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit…
a505b50 
… (generated)

algolia/api-clients-automation#3696

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit…
178b542 
… (generated)

algolia/api-clients-automation#3696

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 3, 2024
@algolia-bot @febeck @millotp
fix(specs): update analytics and abtesting max pagination query limit…
31a33c3 
… (generated)

algolia/api-clients-automation#3696

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Fernando Beck <fe.beck25@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shortcuts shortcuts shortcuts approved these changes
@JonathanMontane JonathanMontane Awaiting requested review from JonathanMontane
@cdhawke cdhawke Awaiting requested review from cdhawke
@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation
+1 more reviewer
@millotp millotp millotp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@febeck @algolia-bot @shortcuts @cdhawke @millotp