feat(sdk): implement close_session method in Sandbox client #449 #451
+42
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bird2426
force-pushed
the
close-session
branch
from
43db9a1 to
0f32929
Compare
BCeZn
reviewed
Feb 9, 2026
| @pytest.mark.need_admin | ||
| @SKIP_IF_NO_DOCKER | ||
| @pytest.mark.asyncio | ||
| async def test_sdk_close_session(admin_remote_server): |
Collaborator
There was a problem hiding this comment.
没必要使用admin_remote_server, 可以看看sandbox_instance这个fixture
|
lianzhanbiao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
- Use sandbox_instance fixture instead of admin_remote_server - Remove unused unit test file - Revert other changes to align with master
bird2426
force-pushed
the
close-session
branch
from
8bb7fc6 to
b300c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #449