Feature/fix dense embedding export in dssmv2#213
Merged
tiankongdeguiji merged 8 commits intoalibaba:masterfrom Jul 23, 2025
Merged
Feature/fix dense embedding export in dssmv2#213tiankongdeguiji merged 8 commits intoalibaba:masterfrom
tiankongdeguiji merged 8 commits intoalibaba:masterfrom
Conversation
tiankongdeguiji
requested changes
Jul 22, 2025
tiankongdeguiji
requested changes
Jul 22, 2025
Collaborator
tiankongdeguiji
left a comment
tiankongdeguiji
left a comment
There was a problem hiding this comment.
bump up a version
tiankongdeguiji
requested changes
Jul 23, 2025
tiankongdeguiji
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dense embedding(autodis and mlp) export fails for dssm_v2. The embedding should be splited for each tower, so the state dict should be adapted in this scenario.