Skip to content

feat(skills): include behavior and impact in native and delegated reviews - #2029

Open
lizhengfeng101 wants to merge 2 commits into
mainfrom
feat/skill-opt-in-analysis
Open

lizhengfeng101 wants to merge 2 commits into
mainfrom
feat/skill-opt-in-analysis

Conversation

@lizhengfeng101

Copy link
Copy Markdown
Contributor

Description

The native skill now asks OCR v1.14.0 or later for behavior and impact analysis on fresh commit and range reviews by default. A request to review a commit is enough; the caller does not have to know the flag. Workspace reviews, previews, resumes, SARIF output, and explicit requests to skip analysis keep their existing invocation. The CLI default does not change.

The standalone skill and its plugin mirror distinguish Review findings and coverage from Analysis execution and the model's assessment of completeness. This keeps a partial investigation from being presented as a clean review. Analysis has a separate token budget, so eligible reviews can incur additional model usage.

In delegated reviews, the host considers the same user-facing question while reading the diff, including workspace changes. There is no new flag, separate native run, or OCR provider requirement. The host reports concrete impacts separately from defect counts and omits the section when it has nothing material to add.

Validation

  • make check and make test passed (28 packages).
  • Plugin manifest and in-repository link checks passed; the existing Cursor manifest-path warning remains. The standalone and plugin instructions match apart from the plugin mirror notice.
  • Exercised a delegate workspace preview with two removed files: the public interface was listed as deleted and available on the old side, the explicitly excluded path remained user_exclude, and neither counted as reviewable.
  • Both required pre-commit ocr review runs selected zero files: the changed Markdown files were excluded as unsupported_ext. The documented flags and result fields were checked against the v1.14.0 implementation separately.

Related Issues

Refs #2024 (part of #2023); builds on #1937. The default-on behavior for eligible skill invocations supersedes the opt-in wording in the original issue; snapshot management is out of scope.

AI Disclosure

OpenAI Codex (gpt-6.2-astra) was used for the skill changes, validation, and PR preparation.

@github-actions

Copy link
Copy Markdown
Contributor

✅ OpenCodeReview: Review skipped: no items were selected.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant