Skip to content

ci.yml: added tengine test cases using test-nginx lib #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chobits merged 3 commits into from
Nov 14, 2022
Merged

ci.yml: added tengine test cases using test-nginx lib #1686

chobits merged 3 commits into from
Nov 14, 2022

Conversation

@chobits
Copy link
Member

@chobits chobits commented Nov 11, 2022 •
edited
Loading

  1. run tengine cases that uses test-nginx lib in tests/test-nginx/cases/ with minor changes
  2. clear deprecated cases in tests/test-nginx/cases/ (these features had been replaced by nginx, so the cases are deprecated.
  3. fixed accidental failure of some test cases in github CI/CD workflow: fastcgi_check.t and reqstat.t

@chobits
ci.yml: run tengine test cases using test-nginx lib
8ba1b97 
1. modified ci.yml: run tengine test cases using test-nginx lib
2. remove deprecated syslog.t and limit_upstream_tries.t
   (this feature is replaced by similar one from nginx
3. fixed user_agent.t: remove ngx_echo dependence via using "return"
   directive
@chobits
fixed fastcgi_check.t: cannot listen on dns server port
26d3831 
Use "127.0.0.01:8xxx" instead of "127.0.0.1:8xxx".
Otherwise, port() in Nginx.pm will listen on that port firstly,
which makes fastcgi_daemon() fail to open port.
@chobits
fixed reqstat.t: reduce the checking accuracy of ups_rt time
991d653
@chobits
Copy link
Member Author

chobits commented Nov 11, 2022 •
edited
Loading

After this pr, only nginx-tests/*.t are not included into CI/CD workflow. See those cases in https://github.com/alibaba/tengine/tree/master/tests/nginx-tests/nginx-tests

May create a new workflow action(new .yml file) for nginx-tests/*.t, too many cases here.

@chobits
Copy link
Member Author

chobits commented Nov 11, 2022

cc @u5surf for modifying ci.yml

chobits
chobits commented Nov 11, 2022
View reviewed changes
tests/test-nginx/cases/user_agent.t
location /exact {
if ($browser = 1) {
echo "msie6";
return 200 "msie6\n";
Copy link
Member Author

@chobits chobits Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dependence of ngx_echo module.

@chobits
Copy link
Member Author

chobits commented Nov 11, 2022

new added cases see here:

https://github.com/alibaba/tengine/actions/runs/3444860481/jobs/5747915651

image

@chobits chobits requested a review from wa5i November 11, 2022 12:18
@chobits chobits merged commit 3652122 into alibaba:master Nov 14, 2022
@chobits chobits added this to the 2.4.0 milestone Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wa5i wa5i Awaiting requested review from wa5i

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

1 participant

@chobits