dynamic resolve: fixed multiple retries for one server #1712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If upstream one server has multiple static addresses, dynamic resolve module will resolve hostname multiple times wrongly with some dns error.
chobits
commented
Nov 29, 2022
| host = server[i].host; | ||
| if (ngx_inet_addr(host.data, host.len) == INADDR_NONE) { | ||
| if (server[i].naddrs > 1) { | ||
| server[i].naddrs = 1; |
Member
Author
There was a problem hiding this comment.
Its tricky, but makes no changes to nginx core.
chobits
added a commit
to chobits/tengine
that referenced
this pull request
Aug 4, 2023
If upstream one server has multiple static addresses, dynamic resolve module will resolve hostname multiple times wrongly with some dns error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one upstream server with hostname has multiple static addresses, dynamic resolve module will resolve hostname multiple times wrongly with some dns error.
Try to fix #1709.
More details, see #1709 (comment)