added test-nginx-core.yml: test nginx core with nginx-tests cases #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
For workflow results, https://github.com/alibaba/tengine/actions/runs/3799813002/jobs/6462689126
|
chobits
commented
Dec 29, 2022
| # NOTE: | ||
| # For "-D T_NGX_MODIFY_DEFAULT_VALUE=0", we dont compile the source included in this macro, otherwise some nginx-tests cases tests will fail. | ||
| ./configure \ | ||
| --with-cc-opt="-D T_NGX_MODIFY_DEFAULT_VALUE=0 -D T_NGX_HTTP_IMAGE_FILTER=0" \ |
Member
Author
There was a problem hiding this comment.
- off T_NGX_MODIFY_DEFAULT_VALUE for that tengine modified default value of some directives, such as
worker_processes n;- nginx core default value of
worker_processes nis 1, tengine default value is<cpu_number>. If nginx-tests cases run with tengine default value, they may fail.
- nginx core default value of
- off T_NGX_HTTP_IMAGE_FILTER for unresolved bug: image_filter.t case failed: tengine feature image_filter_crop_offset #1720
chobits
commented
Dec 29, 2022
| [ myca_extensions ] | ||
| basicConstraints = critical,CA:TRUE | ||
| subjectAltName = IP:127.0.0.1 |
Member
Author
There was a problem hiding this comment.
updated from nginx/nginx-tests repo
wangfakang
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worker_processesdirective.skipped: must be root, ignored, these two skipped cases will be re-runned as root at last.