Bugfix: fix NTLS cert check, move sign/enc certficate to upstream #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongbeiouba
force-pushed
the
fix/ntls_cert
branch
3 times, most recently
from
75409d2 to
cc58476
Compare
dongbeiouba
changed the title
dongbeiouba
force-pushed
the
fix/ntls_cert
branch
20 times, most recently
from
464a403 to
66ec559
Compare
Update to nginx 1.22.1 (alibaba#1719) add reject_handshake, but not fully consider the NTLS. That's okay if no ssl_certificate is configured but ssl_sign_certificate and ssl_enc_certificate are configured when NTLS is enabled. Move sign_certificate, enc_certificate to upstream to adapt to nginx 1.22.1. Rename ngx_openssl_ntls to ngx_tongsuo_ntls. Add test-nginx-ntls CI.
dongbeiouba
force-pushed
the
fix/ntls_cert
branch
from
66ec559 to
fdff37b
Compare
Contributor
|
LGTM |
wa5i
approved these changes
Apr 18, 2023
chobits
reviewed
Apr 19, 2023
| @@ -0,0 +1,63 @@ | |||
| name: test tengine ntls | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to nginx 1.22.1 (#1719) add reject_handshake, but not fully consider the NTLS. That's okay if no ssl_certificate is configured but ssl_sign_certificate and ssl_enc_certificate are configured when NTLS is enabled.
Move sign_certificate, enc_certificate to upstream to adapt to nginx 1.22.1.
Rename ngx_openssl_ntls to ngx_tongsuo_ntls.
Add test-ntls CI.