Skip to content

fixed segfault in ngx_ssl_shutdown() with ssl_async enabled #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chobits merged 1 commit into from
Jun 30, 2023
Merged

fixed segfault in ngx_ssl_shutdown() with ssl_async enabled #1795

chobits merged 1 commit into from
Jun 30, 2023

Conversation

@foxriver1025
Copy link
Contributor

@foxriver1025 foxriver1025 commented Jun 26, 2023

Fix bug
Modify "ngx_ssl_shutdown" process:

  1. "if (n == 1)" needs "ngx_del_async_conn", so add the code
  2. "if (sslerr == SSL_ERROR_ZERO_RETURN || ERR_peek_error() == 0)" move behind "if (sslerr == SSL_ERROR_WANT_ASYNC)", if job is paused, needs to call "ngx_ssl_shutdown" again.
  3. In "if (sslerr == SSL_ERROR_ZERO_RETURN || ERR_peek_error() == 0)" branch, no need "ngx_del_async_conn", because it must be invoked before, so delete the code.

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@foxriver1025 foxriver1025 force-pushed the master branch 2 times, most recently from c07f9bf to 3c7a36d Compare June 26, 2023 06:36
@foxriver1025 foxriver1025 mentioned this pull request Jun 26, 2023
Closed
@lianglli lianglli requested review from jiuzhoucui and lianglli and removed request for lianglli June 26, 2023 12:27
chobits
chobits reviewed Jun 28, 2023
View reviewed changes
chobits
chobits reviewed Jun 29, 2023
View reviewed changes
@chobits chobits merged commit 565d4a3 into alibaba:master Jun 30, 2023
@chobits chobits changed the title fix tengine coredump bug with ssl_async on. issues#1793 fixed segfault with ssl_async enabled Jun 30, 2023
@chobits chobits changed the title fixed segfault with ssl_async enabled fixed reload segfault with ssl_async enabled Jun 30, 2023
@chobits chobits changed the title fixed reload segfault with ssl_async enabled fixed segfault on reload with ssl_async enabled Jun 30, 2023
@chobits chobits changed the title fixed segfault on reload with ssl_async enabled fixed segfault in ngx_ssl_shutdown() with ssl_async enabled Jun 30, 2023
This was referenced Jul 10, 2023
Closed
Open
@lianglli lianglli added this to the 3.0.0 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chobits chobits chobits left review comments

@jiuzhoucui jiuzhoucui Awaiting requested review from jiuzhoucui

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

segfault in ngx_ssl_shutdown() with ssl_async on

4 participants

@foxriver1025 @CLAassistant @chobits @lianglli