Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Model cards update - #136

Merged
AkshitaB merged 5 commits into
masterfrom
model-cards-update
Sep 25, 2020
Merged

Model cards update#136
AkshitaB merged 5 commits into
masterfrom
model-cards-update

Conversation

@AkshitaB

Copy link
Copy Markdown
Contributor

Added a json template to easily fill in model card information.
Also partially updated the information for TransformerQA (RC) model.

@AkshitaB
AkshitaB requested a review from dirkgr September 25, 2020 21:09
Comment on lines +47 to +53
"dataset": "The TransformerQA model was fine-tuned on SQuAD train set.
The underlying BERT model was pretrained on BooksCorpus (800M words) (Zhu et al.,2015)
and English Wikipedia (2,500M words).",
"motivation": "For the pretrained BERT model, document-level corpora were used rather than a shuffled sentence-level corpus
such as the Billion Word Benchmark (Chelba et al., 2013) in order to extract long contiguous sequences",
"preprocessing": "For the pretrained BERT model, only the text passages were extracted from English Wikipedia;
lists, tables, and headers were ignored.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to show this in the demo, we'll need a way to embed links and other simple markup in this text. I wonder how @jonborchardt feels about parsing Markdown? :-P

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should fully embrace using markdown where it makes sense
there is no issue displaying it in the ui

that being said, im not sure what uses these fields right now.. but md support currently does not exist in the allennlp demo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the email I just sent, I am also proposing that we support latex and images. 😅

@AkshitaB
AkshitaB merged commit 0cb9e0f into master Sep 25, 2020
@AkshitaB
AkshitaB deleted the model-cards-update branch September 25, 2020 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants