Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Flickr30k - #285

Merged
dirkgr merged 325 commits into
mainfrom
flickr30k
Jun 25, 2021
Merged

Flickr30k#285
dirkgr merged 325 commits into
mainfrom
flickr30k

Conversation

@jacob-morrison

Copy link
Copy Markdown
Contributor

Adding a dataset reader, model, and training config for flickr30k image retrieval

@jacob-morrison
jacob-morrison requested a review from dirkgr June 24, 2021 01:15
@jacob-morrison
jacob-morrison marked this pull request as ready for review June 24, 2021 01:15
Comment thread allennlp_models/vision/dataset_readers/flickr30k.py Outdated
Comment thread allennlp_models/vision/dataset_readers/flickr30k.py Outdated
Comment thread allennlp_models/vision/dataset_readers/flickr30k.py
Comment thread allennlp_models/vision/dataset_readers/flickr30k.py
Comment thread allennlp_models/vision/dataset_readers/flickr30k.py Outdated
Comment thread allennlp_models/vision/models/vilbert_image_retrieval.py Outdated
Comment thread allennlp_models/vision/models/vilbert_image_retrieval.py Outdated
Comment thread allennlp_models/vision/models/vilbert_image_retrieval.py Outdated
Comment thread allennlp_models/vision/models/vilbert_image_retrieval.py
Comment thread allennlp_models/vision/predictors/vilbert_ir.py Outdated
@jacob-morrison
jacob-morrison requested a review from dirkgr June 24, 2021 23:39

@dirkgr dirkgr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small changes now

Comment thread allennlp_models/vision/dataset_readers/flickr30k.py Outdated
Comment thread allennlp_models/vision/dataset_readers/flickr30k.py Outdated
Comment thread allennlp_models/vision/dataset_readers/flickr30k.py Outdated
Comment thread tests/vision/dataset_readers/flickr30k_test.py Outdated
@jacob-morrison
jacob-morrison requested a review from dirkgr June 25, 2021 00:42
Comment thread tests/vision/dataset_readers/flickr30k_test.py Outdated
@jacob-morrison
jacob-morrison requested a review from dirkgr June 25, 2021 20:23
@dirkgr
dirkgr merged commit e47da99 into main Jun 25, 2021
@dirkgr
dirkgr deleted the flickr30k branch June 25, 2021 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants