Open
Conversation
* Creating the softmax_W tensor on CPU makes it transfer the tensor from CPU to GPU for every batch during test time (where full softmax is used), slowing down the code by 5x or so. * Transposing softmax_W is a large operation compared to transposing input and output vectors, increasing the speed of full softmax further
Contributor
|
Thanks for the PR! I put the softmax variables on CPU for training as they occupy a lot of memory and were overwhelming the poor 8 GB GeForce GTX 1080 GPUs I originally used to train the ELMo model. Can you make the device placement for the softmax configurable? Or place them on GPU for testing only (by checking the value of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By profiling using timeline from Tensorflow we observe the following


Before -
After -
The big MEMCPYHtoD and big Transpose before MatMul are gone