fix(rpc-types-mev): serialize EthCallBundle timestamp/timeout/gas_limit as plain integers#3763
Open
vanityKoa wants to merge 1 commit intoalloy-rs:mainfrom
Open
fix(rpc-types-mev): serialize EthCallBundle timestamp/timeout/gas_limit as plain integers#3763vanityKoa wants to merge 1 commit intoalloy-rs:mainfrom
vanityKoa wants to merge 1 commit intoalloy-rs:mainfrom
Conversation
…it as plain integers
vanityKoa
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EthCallBundle's timestamp, timeout, and gas_limit fields use
with = "alloy_serde::quantity::opt", which serializes them as hex strings (e.g. "0x3e8"). However, Flashbots mev-geth defines these as plain Go integer types (*uint64/*int64), and Go's standard JSON unmarshaler rejects hex strings for numeric types.Fix: switch to
deserialize_withonly (accept hex on input, serialize as plain integers), matching the pattern already used by EthSendBundle's min_timestamp/max_timestamp in the same file.