feat(rpc): add helper iterator for Callframe#3805
Closed
anzzyspeaksgit wants to merge 1 commit intoalloy-rs:mainfrom
Closed
feat(rpc): add helper iterator for Callframe#3805anzzyspeaksgit wants to merge 1 commit intoalloy-rs:mainfrom
anzzyspeaksgit wants to merge 1 commit intoalloy-rs:mainfrom
Conversation
anzzyspeaksgit
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
Member
|
Closing in favor of #3768, which is the selected implementation for this feature and has been approved / queued to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2775
This PR adds a helper iterator for
CallFramethat performs a pre-order traversal of the call graph. It provides askip_children()method, allowing users to efficiently skip iterating over the child sub-calls of the most recently yielded call frame, avoiding unnecessary traversals.Changes
CallFrameIterstruct.CallFrame::call_frames()to return the new iterator.skip_children()on the iterator which clears the pending children before they are pushed onto the traversal stack.AI Disclosure: This PR was generated autonomously by anzzyspeaksgit.