Merged
Conversation
…en an output was mandatory but the glob found no files, an empty token was propagated. Now, if no files match: a list is propagated for mandatory outputs, while an empty token is propagated for optional outputs. Moreover, this commit streamlines command output processing by removing the manual manipulation of glob results and instead leveraging the single logic already present. This same issue with empty globs was previously solved in #472; a regression test has now been added to prevent future occurrences.
Collaborator
Author
|
Added test in common-workflow-language/cwl-v1.3/pull/95 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #989 +/- ##
==========================================
+ Coverage 73.74% 73.79% +0.05%
==========================================
Files 91 91
Lines 12481 12480 -1
Branches 2186 2186
==========================================
+ Hits 9204 9210 +6
+ Misses 2749 2745 -4
+ Partials 528 525 -3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue introduced in #959. Before this commit, when an output was a mandatory list of files but the glob found no files, an empty token was propagated. Now, if no files match: a list is propagated for mandatory outputs, while an empty token is propagated for optional outputs.
Moreover, this commit streamlines command output processing by removing the manual manipulation of glob results and instead leveraging the
singlelogic already present in theCWLCommandOutputProcessor.This same issue with empty globs was previously solved in #472; a regression test has now been added to prevent future occurrences.