Skip to content

Issue with multiple solvers#363

Merged
alphaville merged 4 commits intomasterfrom
fix/362-multiple-solvers
Nov 7, 2024
Merged

Issue with multiple solvers#363
alphaville merged 4 commits intomasterfrom
fix/362-multiple-solvers

Conversation

@alphaville
Copy link
Copy Markdown
Owner

@alphaville alphaville commented Nov 4, 2024 •
edited
Loading

Main Changes

  • Making some casadi-generated functions static (e.g., casadi_sq and casadi_fmin)

Associated Issues

TODOs

  • Documentation
  • All tests must pass
  • Update CHANGELOG(s)
  • Update webpage documentation
  • Bump versions (in CHANGELOG, Cargo.toml and VERSION)

@alphaville alphaville self-assigned this Nov 4, 2024
@alphaville alphaville added python issue related to python linux-ubuntu Ubuntu OS labels Nov 4, 2024
@wrseif
Copy link
Copy Markdown

wrseif commented Nov 4, 2024 •
edited
Loading

@alphaville it seems to work with these changes, thanks.
however the only functions that i needed to make static are casadi_fabs, casadi_fmax, casadi_sq, casadi_fmin but i noticed you also added casadi_hypot, casadi_sign.

is it possible there's additional functions that may cause issues depending on the casadi functions used?

@alphaville
Copy link
Copy Markdown
Owner Author

alphaville commented Nov 5, 2024

is it possible there's additional functions that may cause issues depending on the casadi functions used?

I'll double-check

@alphaville
Copy link
Copy Markdown
Owner Author

alphaville commented Nov 5, 2024

@wrseif I've looked into the code generator of CasADi and it seems that the functions to take into account are:

fncs_list = ["casadi_sq", "casadi_fmax",
    "casadi_fmin", "casadi_hypot", "casadi_sign",
    "casadi_log1p", "casadi_expm1"]

@alphaville
feat(optimizer_builder): make casadi functions static
3a5fa59 
About:
According to code_generator.cpp (Casadi), the functions to
be made static are casadi_sq, casadi_fmax,
casadi_fmin, casadi_hypot, casadi_sign,
casadi_log1p, and casadi_expm1; all done
@alphaville alphaville marked this pull request as ready for review November 5, 2024 15:34
@alphaville
fix(362): remove unnecessary imports
1eb10b8 
Remove unnecessary imports (fileinput, warning, datetime)
and update CHANGELOG and VERSION (opengen)
ruairimoran
ruairimoran approved these changes Nov 5, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ruairimoran ruairimoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alphaville alphaville merged commit 841c913 into master Nov 7, 2024
@alphaville alphaville deleted the fix/362-multiple-solvers branch May 7, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruairimoran ruairimoran ruairimoran approved these changes

Assignees

@alphaville alphaville

Labels

linux-ubuntu Ubuntu OS python issue related to python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple solvers cause compiling issue on ubuntu (works fine on mac)

3 participants

@alphaville @wrseif @ruairimoran