Conversation
|
I don't think my changes are related to the failing test |
|
The failed tests are related to some things Caleb is working on, not yours. |
ekwoka
left a comment
There was a problem hiding this comment.
Makes sense! Just remove the ambiguity
PR Review: #4430 — Clearer example for x-bindType: Docs What's happening (plain English)The <div x-data="{ placeholder: 'Type here...' }">
<input type="text" x-bind:placeholder="placeholder">
</div>The variable name Other approaches considered
Changes MadeCreated #4742 which cherry-picks this change but uses Test ResultsDocs-only change — no tests needed or affected. Code ReviewThe contributor correctly identified a real readability issue. The only problem is the naming convention: SecurityNo security concerns identified. VerdictThis is a good catch — the ambiguity between Reviewed by Claude |
Hey, first of all thanks for making alpine - it's a breath of fresh air to use in the modern web stack for someone who is not a "frontend guy"
While I was reading through the docs I was quite confused because
placeholderwas both a variable name and an attribute for the input field. It took me unreasonably long to figure it out and I believe changing the variable name slightly would have helped me grok it faster.Cheers