move dependencies from monorepo root to correct packages#4550
move dependencies from monorepo root to correct packages#4550Igloczek wants to merge 1 commit intoalpinejs:mainfrom
Conversation
PR Review: #4550 — move dependencies from monorepo root to correct packagesType: Refactor What's happening (plain English)
The result: if someone Other approaches considered
Changes MadeNo changes made. The PR is clean as-is. Test Results
Code Review
SecurityNo security concerns identified. VerdictMerge. This is a correct, minimal metadata fix. It moves two dependencies to where they belong — the packages that actually import them. Zero behavior change today (esbuild bundles everything), but it fixes the published npm package metadata so The contributor's framing about "hopefully disabling bundling later" is aspirational and not this PR's concern — but the fix itself stands on its own merits as correct package metadata. Reviewed by Claude |
package specific dependencies should always be defined inside the package, not in the monorepo root
in normal npm package scenario this would lead to the errors, but since all stuff, including external dependencies is bundled, esbuild can "borrow" the missing deps from the root, hiding the underlying problem
this PR is meant to move the deps into their correct places, so later on, hopefully, the bundling can be disabled, and the npm packages, will become actual npm packages, not CDN-ish builds, but served using NPM