update x-cloak CSS to allow conditional disabling#4712
Closed
browner12 wants to merge 1 commit intoalpinejs:mainfrom
Closed
update x-cloak CSS to allow conditional disabling#4712browner12 wants to merge 1 commit intoalpinejs:mainfrom
x-cloak CSS to allow conditional disabling#4712browner12 wants to merge 1 commit intoalpinejs:mainfrom
Conversation
change the suggested `x-cloak` CSS to specifically only target the boolean `x-cloak` attribute or the attribute with an empty string value (`x-cloak=""`).
this means we will no longer target the attribute when it has a non-empty string value (`x-cloak="off"`).
the benefit this gives is we can conditionally disable the cloaking for elements we know will be visible immediately. this prevents a "blip in" from the hidden to visible state.
Here is a Blade example to show how it would work:
```blade
<div
x-show="jsCondition"
x-cloak="{{ $condition ? 'off' : '' }}"
>Alpine Rocks</div>
```
Collaborator
PR Review: #4712 — update
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change the suggested
x-cloakCSS to specifically only target the booleanx-cloakattribute or the attribute with an empty string value (x-cloak="").this means we will no longer target the attribute when it has a non-empty string value (
x-cloak="off").the benefit this gives is we can conditionally disable the cloaking for elements we know will be visible immediately. this prevents a "blip in" from the hidden to visible state.
Here is a Blade example to show how it would work:
this works because, given these elements:
we get this behavior:
This is already possible by conditionally showing the
x-cloak, but I think this solution provides a better looking code.