Staging/eval adg1736 by Voc94 · Pull Request #2901 · analogdevicesinc/no-OS

Voc94 · 2026-02-17T11:57:58Z

Pull Request Description

Add no-OS project for the EVAL-ADG1736 analog switch evaluation board on MAX32655 platform. Tests switch routing by toggling A/B positions and verifying signal output.

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

CLAassistant · 2026-02-17T11:58:04Z

All committers have signed the CLA.

amiclaus

some comments on my side.

projects/eval-adg1736/src.mk

projects/eval-adg1736/src/examples/basic/basic.mk

amiclaus · 2026-02-17T12:47:03Z

projects/eval-adg1736/src/common/common_data.h

+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
+ * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+*******************************************************************************/
+#ifndef COMMON_DATA_H_


double-underscore guards with a trailing comment:

#ifndef __COMMON_DATA_H__ #define __COMMON_DATA_H__ ... #endif /* __COMMON_DATA_H__ */

amiclaus · 2026-02-17T12:47:45Z

projects/eval-adg1736/src/platform/maxim/platform_src.mk

@@ -0,0 +1,13 @@
+INCS += $(PLATFORM_DRIVERS)/maxim_gpio.h      \


same here: NO_OS_INC_DIRS

amiclaus · 2026-02-17T12:52:34Z

projects/eval-adg1736/src/examples/basic/basic_example.c

+
+	pr_info("Running continuous test...\r\n\r\n");
+
+	while (1) {


you need to have error paths in the while loop such that the cleanup procedure is reached.

raezt · 2026-02-17T17:23:15Z

Please add changelogs or how the comments were addressed after a push.

raezt

some comments from my side.

raezt · 2026-02-17T18:21:15Z

projects/eval-adg1736/src/examples/basic/basic_example.c

+ *   @brief  Basic example source file for eval-adg1736 project.
+ *   @author Alexandru Vasile Popa (Alexandruvasile.Popa@analog.com)
+********************************************************************************
+ * Copyright 2025(c) Analog Devices, Inc.


the year is 2026 (applies to all files)

raezt · 2026-02-17T18:32:35Z

projects/eval-adg1736/src/examples/basic/basic_example.c

+#include "no_os_gpio.h"
+#include "adg1736.h"
+
+/*


maybe move this to the documentation file?

raezt · 2026-02-17T18:33:05Z

projects/eval-adg1736/src/examples/basic/basic_example.c

+err_uart:
+	no_os_uart_remove(uart);
+	return ret;
+}


new line at the EOF (applies to all files)

raezt · 2026-02-17T18:34:30Z

projects/eval-adg1736/src/platform/maxim/parameters.h

+extern struct max_gpio_init_param adg1736_gpio_extra;
+
+/*
+ * ADG1736 test configuration


Voc94 · 2026-02-18T08:31:18Z

changelog v1:

Changed INCS to NO_OS_INC_DIRS in src.mk and platform_src.mk
Fixed header guards in common_data.h (double underscore + trailing comment)
Deleted basic.mk (not needed, handled by build system)
Added error handling for adg1736_set_switch_state and no_os_gpio_get_value in while loop

changelog v2:

Changed copyright year 2025 → 2026 in all files
Moved and adapted wiring documentation from basic_example.c to README.rst(Wiring and LED feedback)
EOF newlines already present in all files(Github diff issue?)

Voc94 · 2026-02-18T08:53:18Z

changelog v3:

Moved GPIO configuration comment from parameters.h to README.rst (renamed Wiring to GPIO Configuration)

amiclaus · 2026-02-19T09:48:08Z

projects/eval-adg1736/src/examples/basic/basic_example.c

+	ret = no_os_gpio_get(&led_green, &led_green_ip);
+	if (ret)
+		goto err_uart;
+	no_os_gpio_direction_output(led_green, NO_OS_GPIO_HIGH);


missing checks.

amiclaus · 2026-02-19T09:48:17Z

projects/eval-adg1736/src/examples/basic/basic_example.c

+	ret = no_os_gpio_get(&led_red, &led_red_ip);
+	if (ret)
+		goto err_led_green;
+	no_os_gpio_direction_output(led_red, NO_OS_GPIO_HIGH);


amiclaus · 2026-02-19T09:49:23Z

projects/eval-adg1736/src/common/common_data.c

+		.extra = GPIO_EXTRA,
+	},
+	.gpio_in2 = {
+		.port = GPIO_IN_PORT,


hmm, same port+pin for both gpios?

amiclaus · 2026-02-19T09:52:02Z

projects/eval-adg1736/src/examples/basic/basic_example.c

+
+	while (1) {
+		/* Test 1: Set to target position, S should see D (HIGH) */
+		ret = adg1736_set_switch_state(dev, ADG1736_SW1, target_state);


the readme states that the example can be used for SW2 too.

Voc94 · 2026-02-19T11:00:17Z

changelog v4:

Add missing return value checks for no_os_gpio_direction_output and no_os_gpio_direction_input
Add TEST_SWITCH macro to select between SW1 and SW2
Use separate GPIO_IN1_PORT/PIN and GPIO_IN2_PORT/PIN macros for clarity (both use the same MCU pin P1.6
since only one switch is tested at a time - user moves wire between P11/P12)
Update example to use configurable switch selection instead of hardcoded ADG1736_SW1

changelog v5:

Add test configuration truth table showing all TEST_SWITCH/TEST_SIDE combinations
Document both TEST_SWITCH and TEST_SIDE macros
Update signal connections section with explicit macro settings for each configuration

Voc94 · 2026-02-19T11:23:11Z

changelog v6:
-Fixed adg1736_sw enum typo to adg1736_switch

amiclaus

one comment on my side, otherwise lgtm.

amiclaus · 2026-02-20T12:19:09Z

projects/eval-adg1736/src/platform/maxim/parameters.h

+#define GPIO_IN1_PORT    1
+#define GPIO_IN1_PIN     6
+#define GPIO_IN2_PORT    1
+#define GPIO_IN2_PIN     6


hmm i think we should use 2 separate hardware pins for in1 and in2

Voc94 · 2026-02-20T12:43:55Z

changelog v7:

Changed IN2 GPIO from P1.6 to P2.0 (J9 pin 5) so IN1 and IN2 use separate pins, enabling independent control of SW1 and SW2
Updated README.rst GPIO configuration, truth table, and wiring examples to reflect IN2 using P2.0 instead of shared P1.6

amiclaus

one comment, otherwise everything is good.

amiclaus · 2026-02-23T11:48:09Z

projects/eval-adg1736/src/common/common_data.c

+	.extra = UART_EXTRA,
+};
+
+struct no_os_gpio_init_param gpio_en_ip = {


since nothing else outside of this file is referencing this, make it static

Add no-OS project for the EVAL-ADG1736 evaluation board with MAX32655FTHR platform support. The project tests the ADG1736 dual SPDT analog switch routing using GPIO signals. Signed-off-by: Alexandru Vasile Popa <Alexandruvasile.Popa@analog.com>

Add README with hardware setup instructions, jumper configuration, wiring connections, and build commands for the EVAL-ADG1736 project. Signed-off-by: Alexandru Vasile Popa <Alexandruvasile.Popa@analog.com>

Voc94 · 2026-02-23T12:09:52Z

changelog v8:

Made gpio_en_ip to static struct in common_data.c as it is only referenced in that file

RaduSabau1 · 2026-02-23T13:36:34Z

The CI error seems unrelated

Voc94 requested review from CiprianRegus, RaduSabau1, amiclaus, buha, cristina-suteu, danmois, dbogdan, raezt, ralucabozdog, ranechita, rbolboac, rbudai98 and stefpopa as code owners February 17, 2026 11:57

github-actions bot added projects documentation labels Feb 17, 2026

amiclaus reviewed Feb 17, 2026

View reviewed changes

Voc94 force-pushed the staging/eval_adg1736 branch 4 times, most recently from d162a4e to 0d2adec Compare February 17, 2026 16:10

raezt reviewed Feb 17, 2026

View reviewed changes

Voc94 force-pushed the staging/eval_adg1736 branch from 0d2adec to a1ec87f Compare February 18, 2026 08:28

Voc94 force-pushed the staging/eval_adg1736 branch from a1ec87f to 2643c53 Compare February 18, 2026 08:51

amiclaus reviewed Feb 19, 2026

View reviewed changes

Voc94 force-pushed the staging/eval_adg1736 branch from 2643c53 to c94f35b Compare February 19, 2026 10:58

Voc94 force-pushed the staging/eval_adg1736 branch from c94f35b to fe9a513 Compare February 19, 2026 11:22

amiclaus reviewed Feb 20, 2026

View reviewed changes

Voc94 force-pushed the staging/eval_adg1736 branch from fe9a513 to 0f5f8ad Compare February 20, 2026 12:41

amiclaus reviewed Feb 23, 2026

View reviewed changes

Voc94 added 2 commits February 23, 2026 13:59

projects: eval-adg1736: Add README documentation

39058e8

Add README with hardware setup instructions, jumper configuration, wiring connections, and build commands for the EVAL-ADG1736 project. Signed-off-by: Alexandru Vasile Popa <Alexandruvasile.Popa@analog.com>

Voc94 force-pushed the staging/eval_adg1736 branch from 0f5f8ad to 39058e8 Compare February 23, 2026 12:08

Comments

Conversation

Voc94 commented Feb 17, 2026

Pull Request Description

PR Type

PR Checklist

Uh oh!

CLAassistant commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raezt commented Feb 17, 2026

Uh oh!

raezt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Voc94 commented Feb 18, 2026

Uh oh!

Voc94 commented Feb 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Voc94 commented Feb 19, 2026

Uh oh!

Voc94 commented Feb 19, 2026

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Voc94 commented Feb 20, 2026

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Voc94 commented Feb 23, 2026

Uh oh!

RaduSabau1 commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Feb 17, 2026 •

edited

Loading