Repository navigation
feat(duckdb): Map type support (experimental) - #1105
Merged
Merged
Conversation
Collaborator
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
danielgafni
changed the base branch from
03-27-feat_experimental_support_for_polars_map.map_datatype
to
graphite-base/1105
March 27, 2026 13:42
danielgafni
changed the title
Map type support (experimental)
danielgafni
force-pushed
the
graphite-base/1105
branch
from
March 27, 2026 13:43
d765ce2 to
a025dc1
Compare
danielgafni
force-pushed
the
03-27-feat_duckdb_map_type_support
branch
from
March 27, 2026 13:43
30aaf8b to
4ab5106
Compare
danielgafni
changed the base branch from
graphite-base/1105
to
03-27-feat_experimental_support_for_polars_map.map_datatype
March 27, 2026 13:44
This was referenced Mar 27, 2026
danielgafni
changed the base branch from
03-27-feat_experimental_support_for_polars_map.map_datatype
to
graphite-base/1105
March 27, 2026 14:00
danielgafni
force-pushed
the
03-27-feat_duckdb_map_type_support
branch
from
March 27, 2026 15:11
4ab5106 to
21bcd11
Compare
danielgafni
force-pushed
the
graphite-base/1105
branch
from
March 27, 2026 15:11
a025dc1 to
787008b
Compare
danielgafni
changed the base branch from
graphite-base/1105
to
03-27-feat_experimental_support_for_polars_map.map_datatype
March 27, 2026 15:11
danielgafni
force-pushed
the
03-27-feat_duckdb_map_type_support
branch
from
March 27, 2026 15:59
21bcd11 to
47ed063
Compare
danielgafni
force-pushed
the
03-27-feat_duckdb_map_type_support
branch
2 times, most recently
from
March 27, 2026 16:25
a9edd35 to
5872aa4
Compare
danielgafni
force-pushed
the
03-27-feat_experimental_support_for_polars_map.map_datatype
branch
from
March 27, 2026 16:25
787008b to
b6a76f4
Compare
danielgafni
commented
Mar 27, 2026
|
|
||
| return self._handle_polars_map_columns(df, map_columns) | ||
|
|
||
| def _handle_ibis_map_columns( |
Collaborator
Author
There was a problem hiding this comment.
in practice this is only applied to versioning columns and keys are guaranteed to be strings
danielgafni
force-pushed
the
03-27-feat_experimental_support_for_polars_map.map_datatype
branch
from
March 27, 2026 16:36
b6a76f4 to
06ccd1d
Compare
danielgafni
force-pushed
the
03-27-feat_duckdb_map_type_support
branch
from
March 27, 2026 16:36
5872aa4 to
8a23d51
Compare
danielgafni
commented
Mar 27, 2026
| assert result is not None | ||
| table = _collect_to_arrow(result) | ||
|
|
||
| assert table.num_rows == 1 |
Collaborator
Author
There was a problem hiding this comment.
better assertions needed
danielgafni
commented
Mar 27, 2026
Comment on lines
+99
to
+100
| assert "frames" in row_0_keys | ||
| assert "audio" in row_0_keys |
Collaborator
Author
There was a problem hiding this comment.
better assertions needed
danielgafni
force-pushed
the
03-27-feat_duckdb_map_type_support
branch
from
March 27, 2026 16:54
8a23d51 to
69c43c6
Compare
danielgafni
force-pushed
the
03-27-feat_experimental_support_for_polars_map.map_datatype
branch
from
March 27, 2026 16:54
06ccd1d to
0872359
Compare
Merge activity
|
graphite-app
Bot
force-pushed
the
03-27-feat_experimental_support_for_polars_map.map_datatype
branch
from
March 27, 2026 17:04
0872359 to
66ee494
Compare
graphite-app
Bot
force-pushed
the
03-27-feat_duckdb_map_type_support
branch
from
March 27, 2026 17:06
69c43c6 to
07ceea3
Compare
graphite-app
Bot
changed the base branch from
03-27-feat_experimental_support_for_polars_map.map_datatype
to
03-27-feat_iceberg_support_map_datatype_experimental__split
March 27, 2026 17:07
graphite-app
Bot
force-pushed
the
03-27-feat_iceberg_support_map_datatype_experimental__split
branch
from
March 27, 2026 17:31
0ff3df4 to
09a6dd4
Compare
Base automatically changed from
03-27-feat_iceberg_support_map_datatype_experimental__split
to
main
March 27, 2026 17:38
graphite-app
Bot
force-pushed
the
03-27-feat_duckdb_map_type_support
branch
from
March 27, 2026 17:39
07ceea3 to
0748322
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://app.graphite.com/github/pr/anam-org/metaxy/1104