Skip to content

feat(map datatype): use narwhals-map when Map datatype is enabled - #1167

Merged
graphite-app[bot] merged 1 commit into
mainfrom
04-03-feat_map_datatype_use_narwhals-map_when_map_datatype_is_enabled
Apr 3, 2026
Merged

graphite-app[bot] merged 1 commit into
mainfrom
04-03-feat_map_datatype_use_narwhals-map_when_map_datatype_is_enabled

Conversation

@danielgafni

@danielgafni danielgafni commented Apr 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Implement backend-agnostic Map datatype support with narwhals-map.

Changelog

narwhals-map is now used for Map datatype operations in Narwhals. This changes the Narwhals datatype from Unknown to narwhals_map.Map and exposes nw.Expr.map namespace for these columns.

Test Plan

Existing tests + new tests for I/O with narwhals_map.Map columns.

Copy link
Copy Markdown
Collaborator Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • graphite:merge - adds this PR to the back of the merge queue
  • graphite:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov

codecov Bot commented Apr 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/metaxy/config/models/metaxy_config.py 83.33% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@danielgafni
danielgafni force-pushed the 04-03-feat_map_datatype_use_narwhals-map_when_map_datatype_is_enabled branch from e24e7d6 to 9adf3d4 Compare April 2, 2026 23:34
@danielgafni
danielgafni force-pushed the 04-03-feat_map_datatype_use_narwhals-map_when_map_datatype_is_enabled branch 6 times, most recently from 5b9b99d to c7f2ca0 Compare April 3, 2026 11:54
@graphite-app

graphite-app Bot commented Apr 3, 2026 •

Copy link
Copy Markdown

Merge activity

…#1167)

## Summary

Implement backend-agnostic `Map` datatype support with [`narwhals-map`](https://pypi.org/project/narwhals-map/).

## Changelog

[`narwhals-map`](https://pypi.org/project/narwhals-map/) is now used for `Map` datatype operations in Narwhals. This changes the Narwhals datatype from `Unknown` to `narwhals_map.Map` and exposes `nw.Expr.map` namespace for these columns.

## Test Plan

Existing tests + new tests for I/O with `narwhals_map.Map` columns.
@graphite-app
graphite-app Bot force-pushed the 04-03-feat_map_datatype_use_narwhals-map_when_map_datatype_is_enabled branch from c7f2ca0 to 9428e7a Compare April 3, 2026 12:09
@graphite-app
graphite-app Bot merged commit 9428e7a into main Apr 3, 2026
30 checks passed
@graphite-app
graphite-app Bot deleted the 04-03-feat_map_datatype_use_narwhals-map_when_map_datatype_is_enabled branch April 3, 2026 12:17

This branch was previously deployed

1 inactive deployment
github-pages — 9428e7a6 Deployed Apr 3, 2026 by graphite-app[bot] via docs / docs #347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant