chore: migrate .goreleaser config to use docker_v2#4608
Open
Conversation
Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Work in progress to migrate/refactor the docker builds to use new
goreleaserfeatures.https://goreleaser.com/customization/dockers_v2/
I know this is in alpha so I can revert the use of v2 and just solve the debug root/non-root issue. It was just overloading in the old syntax to think about everything that was being built.
Here is a link to the feedback discussion for the new feature:
https://github.com/orgs/goreleaser/discussions/6005
IMPORTANT: debug has been changed from non-root -> root.
Dockerfile.debugA new non-root image has been added. This is a subtle change and we should discuss this here.
The other option is to not change the user behavior, keep
debugas is and add adebug-root.This is awkward naming since it's the inverse of the other two images, but might be worth doing as it doesn't change existing behavior of the tagged images.
Each entry builds for 4 platforms: linux/amd64, linux/arm64, linux/ppc64le, linux/s390x.
4 entries × 2 registries × 2 tags = 16 manifest tags, each backed by 4 platform-specific images (64 platform images total).
Type of change
Issue references
Fixes: #4113