Skip to content

Comments

[gmx_mdrun.sh]: Exit Slurm Script with Gromacs Exit Code#70

Merged
andthum merged 1 commit intomainfrom
fix/gmx-mdrun/exit-codes
Aug 25, 2022
Merged

[gmx_mdrun.sh]: Exit Slurm Script with Gromacs Exit Code#70
andthum merged 1 commit intomainfrom
fix/gmx-mdrun/exit-codes

Conversation

@andthum
Copy link
Owner

@andthum andthum commented Aug 25, 2022

[gmx_mdrun.sh]: Exit Slurm Script with Gromacs Exit Code

Type of Change

  • Bug fix.
  • New feature.
  • Code refactoring.
  • Dependency update.
  • Documentation update.
  • Maintenance.
  • Other: Description.
  • Non-breaking (backward-compatible) change.
  • Breaking (non-backward-compatible) change.

Motivation and Context

When gmx mdrun terminates with an error (but not when gmx mdrun terminates due to an INT signal), do some cleanup and finally exit the Slurm job script with the exit code from gmx mdrun.

PR Checklist

  • I followed the guidelines in the Developer's Guide.
  • New/changed code is properly tested.
  • [~] New/changed code is properly documented.
  • New/changed features are tracked in CHANGELOG.rst.
  • The CI workflow is passing.

When `gmx mdrun` terminates with an error (but not when `gmx mdrun`
terminates due to an INT signal), do some cleanup and finally exit the
Slurm job script with the exit code from `gmx mdrun`.
@github-actions github-actions bot added bugfix Pull requests that fix a bug patch Change that results in a new patch version labels Aug 25, 2022
@andthum andthum merged commit 6ea1dee into main Aug 25, 2022
@andthum andthum deleted the fix/gmx-mdrun/exit-codes branch August 25, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull requests that fix a bug patch Change that results in a new patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant