-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular/build): normalize --include paths to posix
#31854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the vitest e2e include test to also include testing relative paths.
25b1b3f to
b8390bd
Compare
This fixes an issue where relative includes didn't work when using backslashes in windows. Closes angular#31829
b8390bd to
f272a9f
Compare
c3af30c to
f272a9f
Compare
--include paths to posix
8f0a274 to
f272a9f
Compare
clydin
approved these changes
Nov 18, 2025
Collaborator
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: @angular/build
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This fixes an issue where relative includes didn't work when using backslashes in windows.
Closes #31829
Green run: https://github.com/angular/angular-cli/actions/runs/19467531139/job/55706346256?pr=31854