Skip to content

fix(@angular/cli): open option in serve command should open localhost when host is 0.0.0.0 #5743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RicardoVaranda wants to merge 2 commits into from
Closed

fix(@angular/cli): open option in serve command should open localhost when host is 0.0.0.0 #5743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b660ebd
fix(@angular/cli): open option in serve command should open localhost…
RicardoVaranda Mar 29, 2017
8eb2343
fix(@angular/cli): open option in serve command should open localhost…
RicardoVaranda Mar 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@angular/cli/tasks/serve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default Task.extend({

const serverAddress = url.format({
protocol: serveTaskOptions.ssl ? 'https' : 'http',
hostname: serveTaskOptions.host,
hostname: serveTaskOptions.host === '0.0.0.0' ? 'localhost' : serveTaskOptions.host,
port: serveTaskOptions.port.toString()
});
let clientAddress = serverAddress;
Expand Down Expand Up @@ -171,7 +171,7 @@ export default Task.extend({

ui.writeLine(chalk.green(oneLine`
**
NG Live Development Server is running on ${serverAddress}
NG Live Development Server is listening on ${serveTaskOptions.host}:${serveTaskOptions.port}, open your browser on ${serverAddress}
**
`));

Expand Down