fix(db): inherit generics in snapshotChanges, stateChanges, auditTrai…#1524
Closed
iNViTiON wants to merge 2 commits intoangular:masterfrom
iNViTiON:my-fix-branch
Closed
fix(db): inherit generics in snapshotChanges, stateChanges, auditTrai…#1524iNViTiON wants to merge 2 commits intoangular:masterfrom iNViTiON:my-fix-branch
iNViTiON wants to merge 2 commits intoangular:masterfrom
iNViTiON:my-fix-branch
Conversation
Member
Author
|
@jamesdaniels look like @firebase willing to support generic type for DataSnapshot. Should we wait for their decision before extend it by ourselve? |
Member
|
@iNViTiON I'm fine implementing here as that pull request has been open for some time... paging @jshcrowthe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l interface
valueChanges already support it (refer to #1214 ) but this one need change to @firebase
I submit separate PR to @firebase here firebase/firebase-js-sdk#590
Checklist
yarn install,yarn testrun successfully? (yes/no; required)Description
link to issue #1214 ang PR firebase/firebase-js-sdk#590
Code sample