(firestore) Update to rxjs pipeable operators#1623
Merged
jamesdaniels merged 3 commits intoangular:masterfrom May 11, 2018
jymdman:firestore-rxjs-pipeable
Merged
(firestore) Update to rxjs pipeable operators#1623jamesdaniels merged 3 commits intoangular:masterfrom jymdman:firestore-rxjs-pipeable
jamesdaniels merged 3 commits intoangular:masterfrom
jymdman:firestore-rxjs-pipeable
Conversation
jamesdaniels
requested changes
May 11, 2018
| .pipe( | ||
| map(action => | ||
| action.payload.docChanges | ||
| .map(change => ({ type: change.type, payload: change })))); |
Member
There was a problem hiding this comment.
shouldn't this be a pipe + map?
Contributor
Author
There was a problem hiding this comment.
action.payload.docChanges isn't Observable, so I think no?
| this.persistenceEnabled$ = zone.runOutsideAngular(() => | ||
| shouldEnablePersistence ? from(this.firestore.enablePersistence().then(() => true, () => false)) | ||
| : of(false) | ||
| shouldEnablePersistence ? Observable.from(this.firestore.enablePersistence().then(() => true, () => false)) |
Member
There was a problem hiding this comment.
we should import of and from rather than using Observable.from and Observable.of
jamesdaniels
approved these changes
May 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? (yes/no; required)Description
Updates firstore to rxjs pipeable operators